-
-
Notifications
You must be signed in to change notification settings - Fork 535
docs: remove unnecessary English from Context example #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove unnecessary English from Context example #1455
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes a redundant English instruction sentence from the Korean translation of the “Replace prop drilling with Context” challenge, keeping the content fully Korean as intended.
Changes:
- Deleted the leftover English explanation line in the Solution section for the Context challenge example.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1024,8 +1024,6 @@ li { | |||
|
|
|||
| `Context.js`에 `ImageSizeContext`를 생성하고 내보냅니다. 리스트를 `<ImageSizeContext.Provider value={imageSize}>`로 감싸 값을 아래로 전달하고 `useContext(ImageSizeContext)`로 `PlaceImage`에서 그것을 읽습니다. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `Context.js`에 `ImageSizeContext`를 생성하고 내보냅니다. 리스트를 `<ImageSizeContext.Provider value={imageSize}>`로 감싸 값을 아래로 전달하고 `useContext(ImageSizeContext)`로 `PlaceImage`에서 그것을 읽습니다. | |
| `Context.js`에 `ImageSizeContext`를 생성하고 내보냅니다. 리스트를 `<ImageSizeContext value={imageSize}>`로 감싸 값을 아래로 전달하고 `useContext(ImageSizeContext)`로 `PlaceImage`에서 그것을 읽습니다. |
영어 원문이 최신 버전이라, Context에서 .Provider를 제거해주시겠어요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인하고 반영했습니다! 안내해주셔서 감사합니다
Size changesDetails📦 Next.js Bundle Analysis for undefinedThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
lumirlumir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 기여 감사합니다!
Context로 prop drilling 대체하기 챌린지 불필요한 영어 문장 제거
위와 같이 이미 한국어로 번역이 되었음에도, 영어 문장이 불필요하게 남아있어 제거하였습니다.
필수 확인 사항
textlint가이드Textlint Guide선택 확인 사항