Youtube Extractor Fix with NewPipe#2489
Conversation
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
Very nice pull request, tested it and works well. I only have a comment about the quality cap.
library/src/commonMain/kotlin/com/lagradost/cloudstream3/extractors/YoutubeExtractor.kt
Outdated
Show resolved
Hide resolved
|
Sorry, for all this forced-pushed, i wanted to created a seprate create pr for the extractor, now |
fire-light42
left a comment
fire-light42
left a comment
There was a problem hiding this comment.
Everything looks good, will merge after testing.
|
Don't Merge for now, almost done with Handling livestreas |
|
That's a freaking cool pull request, as now we can play youtube videos now. Hope someone revive the youtube extension or make a new youtube extension ❤️ |
35, already created a PR for it |
|
Let me know when this pr get merged |
3 participants
1. Bump newpipeextractor
File:
gradle/libs.versions.toml2. YoutubeExtractor Fix
Supports up to 4K.
Testing Mr. Beast's Video 4K Fetched
Screen_recording_20260210_042739.webm
Known Issue - Audio Label's not assiging properly
this mostly happens to additional dubbed audios
i already have some fix, will create another pr for it as it's related to how
newAudioFileis handled