feat: move code diff to separate tab#3286
Closed
calebdw wants to merge 1 commit intorectorphp:mainfrom
Closed
Conversation
Member
|
is the diff default selected after submit or uri has hash target demo? If yes, then i'm ok with this. |
Contributor
Author
|
Yes, it's automatically selected on page load |
Member
|
Hey, thanks for proposal. The idea behind demo is solely using it for simple code snippets to show bugs, typically 5-10 lines of code. It should not be used as "IDE" or coding editor. Saying that it's a feature, not a bug :) One way to try this out would be optional switcher, but that could lead to pretty confusing DX. I'm open to simpler UI that would solve your problem, and navigated to short demo files at the same time. |
Contributor
Author
Member
|
Hey, I forgot to resolve this one. My apologies for delayed reply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Hello!
I've had several issues with the existing diff system:
So I decided to try and change that! This PR moves the diff into a separate
Difftab which allows you to: quickly switch back and forth between the code and the diff, it reduces horizontal scrolling, and every diff section has its own scroll bar if needed.Before
After
Thanks!