Remove @final beforeTraverse() override from DowngradeNullsafeToTernaryOperatorRector#355
Merged
TomasVotruba merged 1 commit intomainfrom Dec 20, 2025
Merged
Conversation
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-remove-before-traverser
branch
from
a39a4dc to
928e111
Compare
TomasVotruba
changed the title
samsonasik
reviewed
Dec 20, 2025
| public function run($value) | ||
| { | ||
| return ($nullsafeVariable1 = $this->extractArrayItemByKey($value)) ? $nullsafeVariable1->value : null; | ||
| return ($nullsafeVariable6 = $this->extractArrayItemByKey($value)) ? $nullsafeVariable6->value : null; |
Member
There was a problem hiding this comment.
The NamedVariableFactory::createVariable() should make increment variable name consistent per file
, I will create PR for it.
Member
There was a problem hiding this comment.
Scope seems can't detect variable exists on new just created variable node so the counter seems need on file level, so static flag may needed, something like:
static $currentFile = $this->file;
if ($currentFile !== $this->file) {
$this->counter = 0;
$currentFile = $this->file;
}
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.