feat(global-header): support multiple support links#2135
feat(global-header): support multiple support links#2135oskarjiang wants to merge 7 commits intoredhat-developer:mainfrom
Conversation
Signed-off-by: Oskar Jiang <oskarjiang94@gmail.com>
Changed Packages
|
Signed-off-by: Oskar Jiang <oskarjiang94@gmail.com>
|
Hi @oskarjiang. Thanks a lot for your contribution, we will take a look if this still matches our needs. Can you add a screenshots of different use cases? Otherwise maybe @Eswaraiahsapram can create some with different use cases. When this doesn't break the current configuration we could also take this as a patch. |
Eswaraiahsapram
left a comment
There was a problem hiding this comment.
Thanks @oskarjiang , for your contribution. I think this should be a patch release rather than a minor one.
Co-authored-by: Eswaraiah Sapram <esapram@redhat.com>
|
My intention was to simply provide a fix for the use-case in your current example. So I think that one still suffices 😊 Also I believe that this change is backwards compatible as is. |
|



Hey, I just made a Pull Request!
The example for customizing the support button doesn't work. From what I can find no such functionality exists in the
<SupportButton/>component currently. Here's a suggestion for how it could be implemented.✔️ Checklist