-
Notifications
You must be signed in to change notification settings - Fork 320
Add rename support for YAML anchors and aliases #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
datho7561
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very helpful as is, but I think it could be better.
|
Thanks for the review! Addressed all the feedback in cda0422. |
datho7561
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change and it's good to go
datho7561
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and is pretty helpful. Thanks, elohmeier!
What does this PR do?
What issues does this PR fix or reference?
Is it tested? How?
npm test -- --grep "YAML Rename"