Skip to content

Conversation

@elohmeier
Copy link
Contributor

What does this PR do?

  • Adds rename support for YAML anchors/aliases, wiring LSP prepare/rename and updating references alongside the anchor definition.

What issues does this PR fix or reference?

  • n/a (new feature)

Is it tested? How?

  • npm test -- --grep "YAML Rename"
  • tested it manually with Neovim

@coveralls
Copy link

coveralls commented Dec 1, 2025

Coverage Status

coverage: 83.653% (-0.6%) from 84.238%
when pulling 2470487 on elohmeier:main
into 1dc7e48 on redhat-developer:main.

@datho7561 datho7561 moved this to Pending review in Java Tooling Dec 1, 2025
@datho7561 datho7561 self-requested a review December 4, 2025 16:37
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful as is, but I think it could be better.

@elohmeier
Copy link
Contributor Author

Thanks for the review! Addressed all the feedback in cda0422.

@elohmeier elohmeier requested a review from datho7561 January 5, 2026 10:49
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change and it's good to go

@elohmeier elohmeier requested a review from datho7561 January 7, 2026 06:16
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and is pretty helpful. Thanks, elohmeier!

@datho7561 datho7561 added this to the 1.20.0 milestone Jan 7, 2026
@datho7561 datho7561 merged commit a38caf0 into redhat-developer:main Jan 7, 2026
4 checks passed
@github-project-automation github-project-automation bot moved this from Pending review to Done in Java Tooling Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants