This repository was archived by the owner on Aug 4, 2024. It is now read-only.
faster round_value#2
Open
snabeljoel wants to merge 1 commit intorenoise:masterfrom
snabeljoel:patch-1
Open
Conversation
Seems to cut about 1/3 of the time. The very fastest would simply be floor(num+0.5) with math.floor being cached, but it's only slightly faster than my suggestion. And btw, all of these variations seem to handle negative values perfectly fine in Lua 5.1, contrary to what someone said (? please verify).
Contributor
|
Nice of you to share these optimizations! Will merge when I'm back from vacation :-) |
Contributor
Author
|
NP. Yeah, but the issue with negative values seems to be a factoid. To be safe, feel free to do a simple test to confirm that it's giving the same results as previously. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to cut about 1/3 of the time.
The very fastest would simply be floor(num+0.5) with math.floor being cached, but it's only slightly faster than my suggestion. And btw, all of these variations seem to handle negative values perfectly fine in Lua 5.1, contrary to what someone said (? please verify).