Skip to content

fix , in visual mode #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightwing wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix , in visual mode #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/vim.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2681,11 +2681,9 @@ export function initVim(CM) {
var repeat = motionArgs.repeat;
var forward = motionArgs.forward === lastSearch.forward;
var increment = (lastSearch.increment ? 1 : 0) * (forward ? -1 : 1);
cm.moveH(-increment, 'char');
motionArgs.inclusive = forward ? true : false;
var curEnd = moveToCharacter(cm, repeat, forward, lastSearch.selectedCharacter);
var curEnd = moveToCharacter(cm, repeat, forward, lastSearch.selectedCharacter, offsetCursor(head, 0, -increment));
if (!curEnd) {
cm.moveH(increment, 'char');
return head;
}
curEnd.ch += increment;
Expand Down
17 changes: 17 additions & 0 deletions test/vim_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3871,6 +3871,23 @@ testVim('vFT', function(cm, vim, helpers) {
helpers.doKeys('F', '1');
helpers.assertCursorAt(0, 0);
}, { value: '1123 123 123'});
testVim('vf,;', function(cm, vim, helpers) {
helpers.doKeys('0', 'v')
helpers.doKeys('f', '.');
eq('ab.', cm.getSelection());
helpers.doKeys(';');
eq('ab.cd.', cm.getSelection());
helpers.doKeys(';');
eq('ab.cd.ef.', cm.getSelection());
helpers.doKeys(',');
eq('ab.cd.', cm.getSelection());
helpers.doKeys(';');
eq('ab.cd.ef.', cm.getSelection());
helpers.doKeys('2', ',');
eq('ab.', cm.getSelection());
helpers.doKeys('2', ',');
eq('ab.', cm.getSelection());
}, { value: 'ab.cd.ef.g'});
testVim('page_motions', function(cm, vim, helpers) {
var value = "x".repeat(200).split("").map((_, i)=>i).join("\n");
cm.setValue(value);
Expand Down