Revert #6611 #7016
Merged
Revert #6611 #7016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspeddro
force-pushed
the
revert-6611
branch
from
69fb167 to
0a1e4fe
Compare
cknitt
approved these changes
Sep 6, 2024
Member
cknitt
left a comment
cknitt
left a comment
There was a problem hiding this comment.
Thanks a lot! As discussed the plan is to bring this back together with #6979 once we have a solution for the binary compatibility issue described in https://github.com/rescript-lang/rescript-compiler/pull/6979/files#r1738735381.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #6611
Issues: #6929, https://github.com/rescript-lang/rescript-compiler/pull/6979/files#r1738735381