Conversation
|
Cursor Agent can help with this pull request. Just |
- Added Wake project button as primary call-to-action for project admins - Button triggers the redeploy mutation to wake the hibernating project - Shows loading state while waking the project - Updated copy to 'You can also run the following command in the Rill CLI' - Kept CLI command display for alternative method - Added success/error notifications Resolves APP-737 Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
cursor
bot
force-pushed
the
cursor/APP-737-hibernation-screen-wake-button-9d61
branch
from
41c532b to
6263755
Compare
- Added MoonCircleOutline icon (104px) for visual recognition - Added full-screen loading state with 'Waking up your project...' message - Added CTANeedHelp component with Discord support link - Applied same visual pattern to read-only viewer state - Consistent with OrganizationHibernatingForAdmins screen patterns Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
- Fixed layout jitter by keeping all elements in DOM - Icon container has fixed 104px dimensions - Moon and loading icons crossfade with 200ms CSS transition - Button stays in place with built-in loading state - CLI section fades to 40% opacity instead of disappearing - No layout shifts during state changes Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
- Added isWaking derived state: true when isPending OR isSuccess - Button now explicitly disabled when isWaking (prevents click handler) - Loading state persists until component unmounts (project refetch) - Icon, header text, and CLI section all use isWaking state - Prevents race condition between mutation success and refetch completion Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
There was a problem hiding this comment.
Two product questions:
- Do we need to explain the CLI helper? The user will almost certainly just press the button in the UI.
- Both "hibernate project" and "wake project" emit toast notifications. IMO the toast notifications are redundant to what's displayed in the main body of the page. Do we need them?
On the code:
- CC @royendo, I believe your status page PR also touches this code? Let's just make sure that we don't duplicate this "wake project" function, and instead have a shared utility.
- @ericokuma, please fix the prettier CI check before merging.
But overall this looks good! Approving.
|
should be fine, i had made something similar but ill merge these changes to project-status PR when fixed and merged :) |
- Removed CLI command display and 'You can also run...' message - Simplified the admin view to just show Wake button and Help link - Applied Prettier formatting Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
The UI already indicates waking state via header text, loading icon, and button state. Error toast kept for important failure feedback. Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
ericokuma
deleted the
cursor/APP-737-hibernation-screen-wake-button-9d61
branch
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| getAdminServiceGetProjectQueryKey, | ||
| } from "@rilldata/web-admin/client"; | ||
| import { getRpcErrorMessage } from "@rilldata/web-admin/components/errors/error-utils"; | ||
| import { Button } from "@rilldata/web-common/components/button"; |
There was a problem hiding this comment.
Old code not removed, file has broken syntax
High Severity
The old implementation was never removed when the new code was added, leaving the file in a completely broken state. The script block contains orphaned syntax (type RpcStatus, } from ... at lines 8–9), duplicate imports of Button, eventBus, and queryClient, two mutation instances (redeployMutation and redeployProjectMutation), and the handleWakeProject function body is interrupted mid-expression by the old wakeProject declaration — making the entire <script> block syntactically invalid. The manage-project slot also renders both the new and old UI (duplicate header, message, and button).
Additional Locations (2)
4 participants
Implements a "Wake project" button as the primary call to action on the post-hibernation screen.
This change provides a direct UI method for users with
manageProjectpermissions to wake a hibernating project, improving user experience by making the most common action more accessible. The CLI command option is retained as a secondary instruction.Checklist:
Linear Issue: APP-737
Note
Medium Risk
Primarily UI/UX changes around triggering
redeployplus query refetching and updated error handling; moderate risk because it changes mutation flow/state handling and the shown diff suggests potential import/logic duplication that could cause build/runtime issues.Overview
Updates the hibernation CTA to make “Wake project” the primary action for users with manage permissions, including a dedicated
handleWakeProjectflow that triggers redeploy and then refetches the project query (exact key).Adds a waking/loading UI state (disabled + loading button, swapping moon/spinner icon, and “Waking up…” header), surfaces redeploy failures via
getRpcErrorMessage, and addsCtaNeedHelpto both manage/read-only hibernation views.Written by Cursor Bugbot for commit b3645cd. This will update automatically on new commits. Configure here.