import apitype.ExplicitNullable #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
approved these changes
Apr 8, 2025
bgentry
force-pushed
the
bg-import-patch-type
branch
from
083fd5d to
a21600b
Compare
bgentry
commented
Apr 8, 2025
Comment on lines
+17
to
+19
| // WithExplicitNullableValidation registers the validator with the | ||
| // ExplicitNullable type. | ||
| func WithExplicitNullableValidation[T any](val *validator.Validate) *validator.Validate { |
Contributor
Author
There was a problem hiding this comment.
@brandur I realized NewValidator above was specifically registering the validator with only the string form of ExplicitNullable which isn't flexible enough. I extracted this helper to at least make it easier to register additional ones. Not set on the API but good enough to move forward on for now, lmk if you have better ideas!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up needing this in the UI, figured it should just be upstreamed instead of copied from the API code.