Bump golangci-lint to 2.7.2 #1107
Merged
+116
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
force-pushed
the
brandur-golangci-lint-2-7-2
branch
from
d3aa191 to
c38677b
Compare
I upgrade golangci-lint recently and I guess it's been a while since we did it in River because I got a whole bunch of new errors. Most are pretty perfunctory, but to be fair, it did catch quite a few docstrings where one of our symbols was named somewhat wrong at the beginning.
brandur
force-pushed
the
brandur-golangci-lint-2-7-2
branch
from
c38677b to
a2bfb56
Compare
bgentry
approved these changes
Dec 22, 2025
Contributor
bgentry
left a comment
bgentry
left a comment
There was a problem hiding this comment.
I'm glad most of the time this library complains about new stuff they're valid and useful fixes. Feels quite different than what I remember from regular Rubocop upgrades :)
Thanks for taking care of this!
Contributor
Author
|
Yeah, totally. At least most of these are improvements. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded golangci-lint recently and I guess it's been a while since we
did it in River because I got a whole bunch of new errors. Most are
pretty perfunctory, but to be fair, it did catch quite a few docstrings
where one of our symbols was named somewhat wrong at the beginning.