Implement selectTextRange, setCaretPosition, getCaretLocation#10
Open
bogdancondurache wants to merge 1 commit intomasterfrom
Open
Implement selectTextRange, setCaretPosition, getCaretLocation#10bogdancondurache wants to merge 1 commit intomasterfrom
bogdancondurache wants to merge 1 commit intomasterfrom
Conversation
bogdancondurache
commented
May 3, 2023
|
|
||
| Args: | ||
| context: the element context handle. | ||
| index: TODO |
Author
There was a problem hiding this comment.
@mmokko Do you have any idea what this index attribute might be doing? Couldn't find a documentation about it anywhere and it's also not really intuitive why there is an index argument.
mmokko
approved these changes
May 3, 2023
Contributor
mmokko
left a comment
mmokko
left a comment
There was a problem hiding this comment.
Unfortunately I have no idea about that index 😄. Usually I just test what it does with the test-app to get any idea.
I have previously added a an action for each API call with the test-app to make sure they don't at least throw an error. If you have time it would be great to add them, but not required.
Definitely good to have more of the API implemented 👍
bogdancondurache
force-pushed
the
bogdan/implement-functions
branch
from
5dfcc4f to
c09d4c8
Compare
bogdancondurache
force-pushed
the
bogdan/implement-functions
branch
from
476e421 to
7a5247e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This still needs some testing