feat(language-server): add python variable line for robot goto#539
Open
leojuurinen-vala wants to merge 2 commits intorobotcodedev:mainfrom
Open
feat(language-server): add python variable line for robot goto#539leojuurinen-vala wants to merge 2 commits intorobotcodedev:mainfrom
leojuurinen-vala wants to merge 2 commits intorobotcodedev:mainfrom
Conversation
Author
|
@d-biehl Do you think this is something to consider? Does it seem good for you, not sure if would require any other updates else where? Been testing it and it seems to work, but this is first change I have done for a VSCode plugin, so might be missing something. |
Member
|
At first glance this looks nice, but I need to take a closer look at it again — it’s Christmas and there’s just so much going on right now… Also, for security reasons you should sign your commits — see the CONTRIBUTION.md guides for more information. I won’t just merge unsigned code so easily… hope you understand ;-) |
Author
|
It is a busy season, hope all goes well and merry :). |
Add parsing of the variables from python files to include their line for navigation from robot.
leojuurinen-vala
force-pushed
the
feature/variable_line_numbers
branch
from
81be7cf to
5d9de5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add parsing of the variables from python files to include their line for navigation from robot.
Root Cause:
Python variables imported from .py files had hardcoded line_no=1, col_offset=0, causing go-to-definition to always jump to the beginning of the file instead of the actual variable definition line.
Solution:
Added AST-based line number extraction that parses Python source files to find the actual line numbers and column offsets where variables are defined. Support for RF >= 7.0.