Dynamic Subscription (BONUS: Allocators): rclcpp#2160
Closed
methylDragon wants to merge 31 commits intorollingfrom
Closed
Dynamic Subscription (BONUS: Allocators): rclcpp#2160methylDragon wants to merge 31 commits intorollingfrom
methylDragon wants to merge 31 commits intorollingfrom
Conversation
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
…down Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
runtime_interface_reflection_allocators
branch
from
1e2eb10 to
165fbd3
Compare
28 tasks
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
runtime_interface_reflection_allocators
branch
from
165fbd3 to
32859cd
Compare
methylDragon
force-pushed
the
runtime_interface_reflection_allocators
branch
3 times, most recently
from
0fd00b4 to
d3077b2
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
runtime_interface_reflection_allocators
branch
from
d3077b2 to
8447d36
Compare
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
runtime_interface_reflection_allocators
branch
from
c52f250 to
c8734b3
Compare
Member
|
I think we could just roll this one into #2077, since it hasn't been merged yet and needs review still. |
Contributor
Author
|
I agree :>, but I'll leave that one open for now until the refactor PRs are in (since this depends on those) |
Signed-off-by: methylDragon <methylDragon@gmail.com>
clalancette
requested changes
Apr 10, 2023
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
I took a brief look here, and pointed out a couple of potential problems.
Comment on lines
-235
to
+247
| bool | ||
| is_serialized() const; | ||
| SubscriptionType | ||
| get_subscription_type() const; |
Contributor
There was a problem hiding this comment.
Just as an FYI, we are going to have to tick-tock this public API.
| rclcpp::MessageInfo message_info; | ||
| message_info.get_rmw_message_info().from_intra_process = false; | ||
|
|
||
| if (subscription->is_serialized()) { |
Contributor
There was a problem hiding this comment.
We'll want to coordinate with @mjcarroll and @alsora here, as this could run into conflict with what they are doing.
Contributor
Author
There was a problem hiding this comment.
I'll wait for their responses!
Member
There was a problem hiding this comment.
I don't think that anything here conflicts with the other executor changes. The execute_* family of functions deals with how to actually dispatch the work, while what I have been working on has been how that work is queued up.
@alsora what do you think?
Contributor
Author
|
Closing in favor of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: ros2/ros2#1405