Conversation
fujitatomoya
left a comment
There was a problem hiding this comment.
please see my comment on ros2/ros2_documentation#5203 (review)
|
This is almost certainly going to change existing files, right? Also, note that, given that we have a ton of repos, it would take a non-trivial amount of work to maintain this. |
|
if we enable this globally, yeah we need to to make sure all repos to pass the github action with pre-commit, that is the work. (my thought is that keep the github action under |
|
@ros-pull-request-builder retest this please |
1 similar comment
|
@ros-pull-request-builder retest this please |
|
Should I close this PR and open a new one in the ros2 repository, targeting each package individually? |
|
@leander-dsouza how would you want to process this? i think we can remove |
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
87945ae to
0f6a1db
Compare
|
@fujitatomoya I have refactored the PR to remove the trailing whitespace :) |
|
Pulls: #2791 |
Description
I have added the following hooks as part of the pre-commit:
end-of-file-fixermixed-line-endingtrailing-whitespaceThis prevents empty whitespace and additional newlines from registering as a separate commit during development.