-
Notifications
You must be signed in to change notification settings - Fork 9
feat: support SPA mode + prerender (Fixes #21 #22 #6) #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixes #21 Fixes #22 Fixes #6 - Support react-router.config.{ts,tsx,js,jsx,mjs} via extension probing - SPA mode (ssr:false): build-time render index.html and remove server output - Prerender: render configured paths to static HTML at build time - Update examples/tests (Tailwind v4 PostCSS, Playwright, fixtures)
Follow-up to keep root e2e runs consistent via `pnpm -r test:e2e`.
Summary of ChangesHello @ScriptedAlchemy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the capabilities of the React Router plugin by integrating full support for Single Page Application (SPA) mode and static prerendering. These additions provide developers with greater flexibility in deployment strategies, allowing for efficient static hosting while leveraging React Router's client-side navigation. The changes also include comprehensive dependency updates and a standardization of end-to-end testing configurations across all examples, enhancing the project's overall stability and developer experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces significant new features, including SPA mode and static prerendering, enhancing the flexibility and deployment options for React Router applications built with Rsbuild. Dependency versions have been updated across the board, and several examples have been added or modified to demonstrate these new capabilities. The changes also include improvements to Playwright test assertions and more robust process management for type generation. Overall, the changes are well-implemented and expand the plugin's utility.
Fixes #22 - Enforce React Router SPA mode route export rules (server-only exports disallowed except root loader; HydrateFallback root-only) - Include `middleware` in server-only export stripping (parity with upstream) - Update SPA mode example routes to use clientAction
Fixes #21
Fixes #22
Fixes #6
Includes follow-up cleanup to standardize e2e scripts across examples.