Skip to content

Conversation

@ScriptedAlchemy
Copy link
Collaborator

Fixes #21

Fixes #22

Fixes #6

Includes follow-up cleanup to standardize e2e scripts across examples.

Fixes #21

Fixes #22

Fixes #6

- Support react-router.config.{ts,tsx,js,jsx,mjs} via extension probing

- SPA mode (ssr:false): build-time render index.html and remove server output

- Prerender: render configured paths to static HTML at build time

- Update examples/tests (Tailwind v4 PostCSS, Playwright, fixtures)
Follow-up to keep root e2e runs consistent via `pnpm -r test:e2e`.
@gemini-code-assist
Copy link

Summary of Changes

Hello @ScriptedAlchemy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the capabilities of the React Router plugin by integrating full support for Single Page Application (SPA) mode and static prerendering. These additions provide developers with greater flexibility in deployment strategies, allowing for efficient static hosting while leveraging React Router's client-side navigation. The changes also include comprehensive dependency updates and a standardization of end-to-end testing configurations across all examples, enhancing the project's overall stability and developer experience.

Highlights

  • SPA Mode Support: Introduced support for Single Page Application (SPA) mode, allowing the plugin to generate a static index.html for client-side routing without a runtime server. This is enabled by setting ssr: false in react-router.config.ts.
  • Static Prerendering: Added static prerendering capabilities, enabling the generation of static HTML files for specified routes at build time. This improves SEO and initial page load performance for static sites, configurable via the prerender option in react-router.config.ts.
  • Dependency Updates: Updated numerous dependencies across the project and its examples to their latest versions, including @rsbuild/core, @react-router/*, react, react-dom, and various development tools.
  • Standardized E2E Testing: Standardized e2e test scripts and Playwright configurations across all examples, ensuring consistent testing practices and improved maintainability. New e2e tests were added for SPA and prerendering modes.
  • Build Process Enhancements: Refined the build process to correctly handle SPA mode and prerendering, including the removal of server build artifacts for static deployments and ensuring type generation runs automatically.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant new features, including SPA mode and static prerendering, enhancing the flexibility and deployment options for React Router applications built with Rsbuild. Dependency versions have been updated across the board, and several examples have been added or modified to demonstrate these new capabilities. The changes also include improvements to Playwright test assertions and more robust process management for type generation. Overall, the changes are well-implemented and expand the plugin's utility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants