Open
Conversation
7ad0c2f to
4bd3866
Compare
This was referenced Jan 16, 2026
4bd3866 to
9dd75f9
Compare
499a791 to
6165add
Compare
Remove remaining ripper dependency in: syntax check, code continue/termination check, show-source, regexp-completion and string-like command arg parse.
6165add to
66e7c60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1024
Fixes #75 and #286
Remove remaining Ripper dependency and completely migrate to Prism.
RubyLex#should_continue?Instead of checking Ripper's state bits, check for IGNORED_NEWLINE token.
When code is continued to the next line, there's probably a IGNORED_NEWLINE token.
RubyLex#check_termination_in_prev_lineWhen multiline code is pasted (without bracketed-paste mode), IRB checks if the last line is connected to the previous line.
Before: Heuristic, find DOT token
After: Compare two syntax trees:
parse(lines.join)andparse(lines[...-1].join)RubyLex#check_code_syntaxChecks if the code is
:valid,:unrecoverable_erroror:recoverable_error.Same as before, use syntax error messages and regexp patterns.
Basic rules
meets end of fileend-of-inputunterminatedis likely to be recoverable erroris not allowedunexpectedorinvalidis likely to be unrecoverable errorinvalidorunexpectederror location is near last token position, it may not be unrecoverable errorChecked with many recoverable-error-code collected by
ruby/ruby/**/*.rb"\n"becomes valid