fix: Update error message to correctly reflect command #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perryqh
reviewed
Jan 29, 2026
| let mut current_section: Option<TeamOwnership> = None; | ||
| let input: String = codeowners_file.replace(&FileGenerator::disclaimer().join("\n"), ""); | ||
| let error_message = "CODEOWNERS out of date. Run `codeowners generate` to update the CODEOWNERS file"; | ||
| let error_message = "CODEOWNERS out of date. Run `codeownership validate` to update the CODEOWNERS file"; |
Contributor
There was a problem hiding this comment.
codeowners generate is correct for codeowners-rs, but not for the ruby gem code_ownership that wraps it.
We'll likely need to at least update code_ownership to fix this bug and possibly rethink how errors are handled in the ruby to rust FFI.
Author
There was a problem hiding this comment.
Sounds good. How would I be able to update this?
Contributor
There was a problem hiding this comment.
Possibilities:
- Make the error message generic "CODEOWNERS out of date. Regenerate the CODEOWNERS file to fix."
- Update RunResult to include error codes, which could be used by
code_ownershipto customize error messages - Temporary solution: the gem post-processes the output: gsub
codeowners generatewithbin/codeownership validate - ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The message indicates to the user to run
generatethe command to run seems to be