Merged
Conversation
… and remove extra closing div tag
5766af5 to
9e8d598
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a problematic global CSS rule that set all span elements to display: block, which was too broad and affected elements beyond its intended scope. The change introduces a new, properly scoped .supervisor-stat CSS class specifically for supervisor volunteer statistics.
Changes:
- Removed global
span { display: block; }CSS rule - Added new
.supervisor-statCSS class with appropriate styling - Updated supervisor views and JavaScript to use the new class instead of the generic
status-btn - Fixed an unrelated bug by removing an extra closing
</div>tag
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| public/assets/css/main.css | Removed global span CSS rule and added new .supervisor-stat class with display, padding, border-radius, font-size, and font-weight properties |
| app/views/supervisors/index.html.erb | Replaced status-btn with supervisor-stat class in legend and volunteer info displays |
| app/javascript/src/dashboard.js | Updated class names to supervisor-stat and added helpful title attributes for accessibility |
| spec/system/supervisors/index_spec.rb | Updated test selectors from .status-btn to .supervisor-stat to match new class names |
| app/views/casa_admins/index.html.erb | Removed extra closing div tag to fix HTML structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5377
What changed, and why?
Remove global span CSS and instead adds new CSS class for volunteer info in the Supervisors table where it was previously using
status-btn(its not a button!).It changes a bit the style in the Admin edit page (see screenshot) but I prefeer the status not taking the whole line but I can work on making sure that also looks the same as prod.
How is this tested? (please write rspec and jest tests!) 💖💪
Tested comparing
mainand this branch in all pages to check styles match.Screenshots please :)
Feelings gif (optional)
https://giphy.com/gifs/XIqCQx02E1U9W