4941 Remove unused and broken shared 'not signed in' auth specs

spec/controllers/donation_sites_controller_spec.rb

@@ -39,16 +39,5 @@
         expect(subject).to be_successful
       end
     end
-
-    context "Looking at a different organization" do
-      let(:object) { create(:donation_site, organization: create(:organization)) }
-      include_examples "requiring authorization"
-    end
-  end
-
-  context "While not signed in" do
-    let(:object) { create(:donation_site) }
-
-    include_examples "requiring authorization"
   end
 end

spec/controllers/items_controller_spec.rb

@@ -198,11 +198,6 @@
       end
     end
 
-    context "Looking at a different organization" do
-      let(:object) { create(:item, organization: create(:organization)) }
-      include_examples "requiring authorization"
-    end
-
     describe "PATCH #remove_category" do
       let(:item_category) { create(:item_category) }
       let!(:item) { create(:item, item_category: item_category) }
@@ -220,10 +215,4 @@
       end
     end
   end
-
-  context "While not signed in" do
-    let(:object) { create(:item) }
-
-    include_examples "requiring authorization"
-  end
 end

spec/controllers/transfers_controller_spec.rb

@@ -128,22 +128,5 @@
         end
       end
     end
-
-    context "Looking at a different organization" do
-      let(:object) do
-        org = create(:organization)
-        create(:transfer,
-               to: create(:storage_location, organization: org),
-               from: create(:storage_location, organization: org),
-               organization: org)
-      end
-      include_examples "requiring authorization", except: %i(edit update destroy)
-    end
-  end
-
-  context "While not signed in" do
-    let(:object) { create(:transfer) }
-
-    include_examples "requiring authorization", except: %i(edit update destroy)
   end
 end

spec/requests/barcode_items_requests_spec.rb

@@ -123,11 +123,6 @@
         expect(subject).to redirect_to(barcode_items_path)
       end
     end
-
-    context "Looking at a different organization" do
-      let(:object) { create(:barcode_item, organization: create(:organization)) }
-      include_examples "requiring authorization"
-    end
   end
 
   context 'while signed in as organization admin' do

spec/requests/distributions_requests_spec.rb

@@ -550,11 +550,6 @@
       include_examples "restricts access to organization users/admins"
     end
 
-    context "Looking at a different organization" do
-      let(:object) { create(:distribution, organization: create(:organization)) }
-      include_examples "requiring authorization"
-    end
-
     describe "PATCH #update" do
       subject { patch distribution_path(distribution_params) }
       let(:partner_name) { "Patrick" }
@@ -939,8 +934,6 @@
   context "While not signed in" do
     let(:object) { create(:distribution) }
 
-    include_examples "requiring authorization"
-
     # calendar does not need signin
     describe 'GET #calendar' do
       before(:each) do

spec/requests/events_requests_spec.rb

@@ -265,13 +265,4 @@
       end
     end
   end
-
-  context "When not signed in" do
-    let(:object) do
-      donation = create(:donation)
-      DonationEvent.publish(donation)
-    end
-
-    include_examples "requiring authorization"
-  end
 end

spec/requests/partner_groups_requests_spec.rb

@@ -112,10 +112,4 @@
       end
     end
   end
-
-  context "While not signed in" do
-    let(:object) { create(:partner_group, organization: organization) }
-
-    include_examples "requiring authorization"
-  end
 end

spec/requests/product_drive_participants_requests_spec.rb

@@ -131,16 +131,5 @@
         expect(response).to have_error(/try again/i)
       end
     end
-
-    context "Looking at a different organization" do
-      let(:object) { create(:product_drive_participant, organization: create(:organization)) }
-      include_examples "requiring authorization"
-    end
-  end
-
-  context "While not signed in" do
-    let(:object) { create(:product_drive_participant) }
-
-    include_examples "requiring authorization"
   end
 end

spec/requests/requests_requests_spec.rb

@@ -170,10 +170,4 @@
       end
     end
   end
-
-  context 'When not signed' do
-    let(:object) { create(:request) }
-
-    include_examples 'requiring authorization'
-  end
 end

spec/requests/storage_locations_requests_spec.rb

@@ -560,16 +560,5 @@ def item_to_h(view_item)
         expect(response.body).to include("Square footage must be greater than or equal to 0")
       end
     end
-
-    context "Looking at a different organization" do
-      let(:object) { create(:storage_location, organization: create(:organization)) }
-      include_examples "requiring authorization"
-    end
-  end
-
-  context "While not signed in" do
-    let(:object) { create(:storage_location) }
-
-    include_examples "requiring authorization"
   end
 end

spec/requests/transfers_requests_spec.rb

@@ -130,22 +130,5 @@
         end
       end
     end
-
-    context "Looking at a different organization" do
-      let(:object) do
-        org = create(:organization)
-        create(:transfer,
-               to: create(:storage_location, organization: org),
-               from: create(:storage_location, organization: org),
-               organization: org)
-      end
-      include_examples "requiring authorization", except: %i(edit update)
-    end
-  end
-
-  context "While not signed in" do
-    let(:object) { create(:transfer) }
-
-    include_examples "requiring authorization", except: %i(edit update)
   end
 end

spec/requests/vendors_requests_spec.rb

@@ -199,11 +199,6 @@
       end
     end
 
-    context "Looking at a different organization" do
-      let(:object) { create(:vendor, organization: create(:organization)) }
-      include_examples "requiring authorization"
-    end
-
     describe "when on vendors index page" do
       it "has the correct import type" do
         get vendors_path(format: 'html')
@@ -212,10 +207,4 @@
       end
     end
   end
-
-  context "While not signed in" do
-    let(:object) { create(:vendor) }
-
-    include_examples "requiring authorization"
-  end
 end

spec/support/authorization_specs.rb

@@ -26,48 +26,3 @@
     end
   end
 end
-
-RSpec.shared_examples "requiring authorization" do |constraints|
-  it "redirects the user to the sign-in page for CRUD actions" do
-    member_params = { organization_id: object.organization.to_param, id: object.id }
-    collection_params = { organization_id: object.organization.to_param }
-
-    (constraints ||= {}).merge!(except: [], only: [])
-    skip_these = constraints[:except] + (%i(index new create show edit update destroy) - constraints[:only])
-
-    unless skip_these.include?(:index)
-      get :index, params: collection_params
-      expect(response).to be_redirect
-    end
-
-    unless skip_these.include?(:new)
-      get :new, params: collection_params
-      expect(response).to be_redirect
-    end
-
-    unless skip_these.include?(:create)
-      post :create, params: collection_params
-      expect(response).to be_redirect
-    end
-
-    unless skip_these.include?(:show)
-      get :show, params: member_params
-      expect(response).to be_redirect
-    end
-
-    unless skip_these.include?(:edit)
-      get :edit, params: member_params
-      expect(response).to be_redirect
-    end
-
-    unless skip_these.include?(:update)
-      get :update, params: member_params
-      expect(response).to be_redirect
-    end
-
-    unless skip_these.include?(:destroy)
-      delete :destroy, params: member_params
-      expect(response).to be_redirect
-    end
-  end
-end