feat: add support for yocto whinlatter#232
feat: add support for yocto whinlatter#232hrueger wants to merge 4 commits intorust-embedded:masterfrom
whinlatter#232Conversation
Due to the renaming of WORKDIR to UNPACKDIR, I had to drop the support for all previous versions.
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the Yocto whinlatter release, building upon PR #228 which added walnascar support. The changes handle the migration from WORKDIR to UNPACKDIR that was introduced in Yocto 5.1 (walnascar), by conditionally setting a compatibility variable based on the detected Yocto version.
Changes:
- Added conditional version detection to set
COMPATIBLE_PACKDIRto eitherUNPACKDIR(for walnascar/whinlatter) orWORKDIR(for earlier versions) - Updated all references from
WORKDIRtoCOMPATIBLE_PACKDIRacross recipe includes and build classes - Added walnascar and whinlatter to the layer compatibility list
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| recipes-devtools/rust/rust-bin-cross.inc | Adds version detection logic and updates directory references to use COMPATIBLE_PACKDIR |
| recipes-devtools/rust/cargo-bin-cross.inc | Adds version detection logic and updates directory references to use COMPATIBLE_PACKDIR |
| conf/layer.conf | Adds walnascar and whinlatter to LAYERSERIES_COMPAT list |
| classes/cargo_bin.bbclass | Adds version detection logic and updates directory references to use COMPATIBLE_PACKDIR |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| inherit rust_bin-common | ||
|
|
||
| python () { | ||
| layerseries = d.getVar("LAYERSERIES_COMPAT_core") |
There was a problem hiding this comment.
The check for layer series compatibility appears incorrect. The variable LAYERSERIES_COMPAT_core typically contains a space-separated list of all compatible layer series, not the current active series. To detect the current Yocto version, use the LAYERSERIES_CORENAMES variable instead, which contains the actual active layer series name. The check should be: layerseries = d.getVar("LAYERSERIES_CORENAMES") followed by if layerseries in ["walnascar", "whinlatter"]:
| layerseries = d.getVar("LAYERSERIES_COMPAT_core") | |
| layerseries = d.getVar("LAYERSERIES_CORENAMES") |
| inherit rust_bin-common | ||
|
|
||
| python () { | ||
| layerseries = d.getVar("LAYERSERIES_COMPAT_core") |
There was a problem hiding this comment.
The check for layer series compatibility appears incorrect. The variable LAYERSERIES_COMPAT_core typically contains a space-separated list of all compatible layer series, not the current active series. To detect the current Yocto version, use the LAYERSERIES_CORENAMES variable instead, which contains the actual active layer series name. The check should be: layerseries = d.getVar("LAYERSERIES_CORENAMES") followed by if layerseries in ["walnascar", "whinlatter"]:
| layerseries = d.getVar("LAYERSERIES_COMPAT_core") | |
| layerseries = d.getVar("LAYERSERIES_CORENAMES") |
| inherit rust_bin-common | ||
|
|
||
| python () { | ||
| layerseries = d.getVar("LAYERSERIES_COMPAT_core") |
There was a problem hiding this comment.
The check for layer series compatibility appears incorrect. The variable LAYERSERIES_COMPAT_core typically contains a space-separated list of all compatible layer series, not the current active series. To detect the current Yocto version, use the LAYERSERIES_CORENAMES variable instead, which contains the actual active layer series name. The check should be: layerseries = d.getVar("LAYERSERIES_CORENAMES") followed by if layerseries in ["walnascar", "whinlatter"]:
| layerseries = d.getVar("LAYERSERIES_COMPAT_core") | |
| layerseries = d.getVar("LAYERSERIES_CORENAMES") |
2 participants
This builds on top of @MrTarantoga's #228 and adds support for
whinlatter.