Conversation
Member
|
According to the Rust Reference, I'm not entirely convinced that we can safely remove the code that references the variable just because the compiler happens to not remove the variable for the kernels in our tests. |
Author
|
Tested it in gobolt and using similar setup current approach got removed but not used |
Contributor
|
The address cannot be removed though. It must be present. The used attribute does not prevent the linker from removing the variable if it's own heuristics determine that it is unused. |
Author
|
good point my bad link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ran the test suite and it seems fine