Skip to content

🎨 format on bucketGet and objectGetLegalHold for async/await#6069

Closed
DarkIsDude wants to merge 0 commit intodevelopment/9.3from
feature/CLDSRV-823/formatting-only
Closed

🎨 format on bucketGet and objectGetLegalHold for async/await#6069
DarkIsDude wants to merge 0 commit intodevelopment/9.3from
feature/CLDSRV-823/formatting-only

Conversation

@DarkIsDude
Copy link
Contributor

Issue: CLDSRV-823

Pull request template

Description

Motivation and context

Why is this change required? What problem does it solve?

Related issues

Please use the following link syntaxes #600 to reference issues in the
current repository

Checklist

Add tests to cover the changes

New tests added or existing tests modified to cover all changes

Code conforms with the style guide

Sign your work

In order to contribute to the project, you must sign your work
https://github.com/scality/Guidelines/blob/master/CONTRIBUTING.md#sign-your-work

Thank you again for contributing! We will try to test and integrate the change
as soon as we can.

@DarkIsDude DarkIsDude self-assigned this Feb 4, 2026
@bert-e
Copy link
Contributor

bert-e commented Feb 4, 2026

Hello darkisdude,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 4, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@codecov
Copy link

codecov bot commented Feb 4, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
8095 1 8094 0
View the top 1 failed test(s) by shortest run time
"after each" hook for "should mimic null version replication by crrExistingObjects, then replicate version"::backbeat routes for replication (same account) "after each" hook for "should mimic null version replication by crrExistingObjects, then replicate version"
Stack Traces | 0.058s run time
The bucket you tried to delete is not empty.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@DarkIsDude DarkIsDude changed the base branch from development/9.2 to development/9.3 February 4, 2026 06:38
@bert-e
Copy link
Contributor

bert-e commented Feb 4, 2026

Branches have diverged

This pull request's source branch feature/CLDSRV-823/formatting-only has diverged from
development/9.3 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/9.3 into feature/CLDSRV-823/formatting-only
  • Rebase feature/CLDSRV-823/formatting-only onto origin/development/9.3

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

@DarkIsDude DarkIsDude requested review from a team, benzekrimaha and delthas February 4, 2026 06:40
@DarkIsDude DarkIsDude force-pushed the feature/CLDSRV-823/formatting-only branch from d6342e9 to 7559941 Compare February 4, 2026 06:50
@bert-e
Copy link
Contributor

bert-e commented Feb 4, 2026

Incorrect fix version

The Fix Version/s in issue CLDSRV-823 contains:

  • 9.2.25

  • 9.3.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.3.0

Please check the Fix Version/s of CLDSRV-823, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Feb 4, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@DarkIsDude DarkIsDude marked this pull request as ready for review February 4, 2026 07:47
@DarkIsDude DarkIsDude closed this Feb 4, 2026
@DarkIsDude DarkIsDude force-pushed the feature/CLDSRV-823/formatting-only branch from 15b087d to 051a2d8 Compare February 4, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants