Adds an option to specify the predictor to use when compression is enabled #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abled and adjusts the jpeg... image size accordingly. This set of changes allows us to generate darktable compatible compressed DNGs because darktable _only_ supports predictor=1 which requires the JPEG image size to be exactly the DNG image size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some raw converters, like darktable, only support
predictor=1when lossless JPEG compression is used. When predictor is 1 it is also necessary to encode the JPEG image without the interleaving trick. With this change we are able to produce compressed DNGs readable by darktable:When
predictoris not specified, the existing behaviour is preserved aspredictordefaults to 6.