Fix missing secondary sidebars on SPECs pages #843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scientific-python-org ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
agriyakhetarpal
changed the title
stefanv
approved these changes
Feb 4, 2026
Member
|
Thank you for tracking this down, @agriyakhetarpal, much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The secondary (shortcuts) sidebar wasn't showing up on individual SPEC pages. The JavaScript code we have for shortcuts in the theme looks for headings that are direct children of
.content-container, butspecs/single.htmlhad an extra<div class="article-content">wrapper around the content. I have removed this wrapper since it isn't defined anywhere in the theme anyway.Tip
Try it out at https://deploy-preview-843--scientific-python-org.netlify.app/specs/spec-0008/