Skip to content

(improvement)Optimize DCAware/RackAware RoundRobinPolicy with host distance caching #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mykaul wants to merge 4 commits into
base: master
Choose a base branch
from
+214 −84
Draft

(improvement)Optimize DCAware/RackAware RoundRobinPolicy with host distance caching #651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f669b96
(improvement)Optimize DCAwareRoundRobinPolicy by removing redundant s…
mykaul Jan 22, 2026
1884f59
(Fix)race condition during host IP address update
mykaul Jan 23, 2026
6282e6f
(improvement)Optimize RackAwareRoundRobinPolicy by caching some host …
mykaul Jan 24, 2026
8f96d39
(improvement)TokenAware round robin policy and others - improved quer…
mykaul Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cassandra/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3831,14 +3831,16 @@
host = self._cluster.metadata.get_host_by_host_id(host_id)
if host and host.endpoint != endpoint:
log.debug("[control connection] Updating host ip from %s to %s for (%s)", host.endpoint, endpoint, host_id)
old_endpoint = host.endpoint
host.endpoint = endpoint
self._cluster.metadata.update_host(host, old_endpoint)
reconnector = host.get_and_set_reconnection_handler(None)
if reconnector:
reconnector.cancel()
self._cluster.on_down(host, is_host_addition=False, expect_host_to_be_down=True)

old_endpoint = host.endpoint
host.endpoint = endpoint
self._cluster.metadata.update_host(host, old_endpoint)
self._cluster.on_up(host)

if host is None:
log.debug("[control connection] Found new host to connect to: %s", endpoint)
host, _ = self._cluster.add_host(endpoint, datacenter=datacenter, rack=rack, signal=True, refresh_nodes=False, host_id=host_id)
Expand Down Expand Up @@ -4241,7 +4243,7 @@
self._scheduled_tasks.discard(task)
fn, args, kwargs = task
kwargs = dict(kwargs)
future = self._executor.submit(fn, *args, **kwargs)

Check failure on line 4246 in cassandra/cluster.py

View workflow job for this annotation

GitHub Actions / test asyncio (3.11) 

cannot schedule new futures after shutdown
future.add_done_callback(self._log_if_failed)
else:
self._queue.put_nowait((run_at, i, task))
Expand Down
Loading
Loading