Skip to content

Conversation

@Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Dec 31, 2025

Describe your changes and provide context

Testing performed to validate your change

@github-actions
Copy link

github-actions bot commented Dec 31, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 6, 2026, 9:09 PM

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 61.61616% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.77%. Comparing base (8f2b982) to head (7bbbff0).

Files with missing lines Patch % Lines
sei-ibc-go/modules/core/types/params.go 0.00% 23 Missing ⚠️
app/upgrades.go 0.00% 7 Missing ⚠️
sei-ibc-go/modules/core/keeper/msg_server.go 60.00% 2 Missing and 2 partials ⚠️
...ei-ibc-go/modules/core/04-channel/keeper/packet.go 50.00% 1 Missing and 1 partial ⚠️
sei-ibc-go/modules/core/keeper/params.go 90.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2649      +/-   ##
==========================================
+ Coverage   43.76%   43.77%   +0.01%     
==========================================
  Files        1906     1908       +2     
  Lines      159036   159134      +98     
==========================================
+ Hits        69597    69664      +67     
- Misses      83038    83070      +32     
+ Partials     6401     6400       -1     
Flag Coverage Δ
sei-chain 45.79% <61.61%> (+0.02%) ⬆️
sei-cosmos 38.20% <ø> (-0.01%) ⬇️
sei-db 69.13% <ø> (ø)
sei-tendermint 47.31% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-ibc-go/modules/core/02-client/keeper/client.go 98.44% <100.00%> (+0.02%) ⬆️
sei-ibc-go/modules/core/02-client/keeper/keeper.go 83.49% <100.00%> (+0.32%) ⬆️
...-go/modules/core/03-connection/keeper/handshake.go 86.50% <100.00%> (+0.33%) ⬆️
...ibc-go/modules/core/03-connection/keeper/keeper.go 92.59% <100.00%> (+0.59%) ⬆️
...ibc-go/modules/core/04-channel/keeper/handshake.go 89.29% <100.00%> (+0.16%) ⬆️
...ei-ibc-go/modules/core/04-channel/keeper/keeper.go 86.74% <100.00%> (+0.49%) ⬆️
sei-ibc-go/modules/core/genesis.go 100.00% <100.00%> (ø)
sei-ibc-go/modules/core/keeper/keeper.go 87.09% <100.00%> (+0.88%) ⬆️
...ei-ibc-go/modules/core/04-channel/keeper/packet.go 94.15% <50.00%> (-0.62%) ⬇️
sei-ibc-go/modules/core/keeper/params.go 90.00% <90.00%> (ø)
... and 3 more

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

func (k Keeper) ConnectionOpenTry(goCtx context.Context, msg *connectiontypes.MsgConnectionOpenTry) (*connectiontypes.MsgConnectionOpenTryResponse, error) {
ctx := sdk.UnwrapSDKContext(goCtx)

if !k.IsInboundEnabled(ctx) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right/best place to check for inbound?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also do this at the core keeper layer not just msg server

@Kbhat1 Kbhat1 requested a review from alexander-sei January 2, 2026 19:55
@Kbhat1 Kbhat1 requested a review from philipsu522 January 2, 2026 20:11
@Kbhat1 Kbhat1 requested review from sei-will and yzang2019 January 2, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants