-
Notifications
You must be signed in to change notification settings - Fork 4
[WIP] Feature/e2e test pyroute2 tc #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
voluntas
wants to merge
39
commits into
develop
Choose a base branch
from
feature/e2e-test-pyroute2-tc
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SoraClient に turn_ports プロパティを追加 - RFC 7065 に準拠した TURN URI パーサーを実装 - UDP、TCP、TLS のポートを正しく分類 - test_turn.py を追加して TURN ポート取得をテスト - UDP ポートがエフェメラルポート範囲内であることを検証
- video_bit_rate を 1000 kbps に設定 - 帯域制限を 500 kbps に設定してテスト
- subprocess を削除し pyroute2.IPRoute に統一 - 帯域制限に tbf (Token Bucket Filter) を使用 - 遅延は netem qdisc で実装 - verify_tc_settings と show_tc_stats を IPRoute で実装 - qdisc の種類 (tbf/netem) を指定できるように改善
- pytest.importorskip で pyroute2 のインポートを管理 - show_webrtc_stats 関数を追加し outbound-rtp 統計を表示 - test_tc_egress_bandwidth_limit で targetBitrate を確認 - targetBitrate が帯域制限値以下であることを assert で検証 - test_tc_egress_multiple_bandwidth_limits と test_tc_egress_delay を削除
…トにVP8ビデオコーデックタイプを追加する。
- TCA_STATS2 から TCA_STATS_BASIC で bytes/packets を取得 - TCA_STATS2 から TCA_STATS_QUEUE で drops/overlimits/requeues を取得 - show_tc_stats と TCEgressManager.get_stats を統一的に修正 - tbf/netem qdisc のみをフィルタリングするように改善
- アサーションエラーを修正 (r0 検証時に誤って r1 を確認していた) - 変数名を明確化 (stats を webrtc_stats, tc_stats, webrtc_stats_after に分離) - 重複コードを関数化 (get_simulcast_outbound_rtp_stats 関数を追加)
- TCA_STATS2 が存在しない場合は continue で次の qdisc をチェック - qdisc オブジェクトから直接統計情報を取得するフォールバックを削除 - Linux 2.6.x 以降では TCA_STATS2 が標準で提供されるため不要 - コードの複雑性を削減
- show_webrtc_stats 関数内で outbound-rtp を抽出してソート - r0, r1, r2 の順序で一貫した表示を保証
- get_default_interface でフォールバック処理を削除し例外を raise するように変更 - ルート権限チェックを pytestmark に統合 - スキップ条件を一元化し reason メッセージを明確化
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.