ci: add Python 3.14 support and update to cibuildwheel 3.2.1 #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarsonZuniga
commented
Oct 17, 2025
CarsonZuniga
commented
- Adds CPython 3.14 to the test matrix and wheel build targets
- Upgrades cibuildwheel to v3.2.1 for official 3.14.0 final support
- Updates sdist build to use Python 3.14
- Ensures prebuilt cp314 wheels are generated for Linux, macOS, and Windows
- Retains Python 2.7 compatibility for legacy users
- Adds CPython 3.14 to the test matrix and wheel build targets - Upgrades cibuildwheel to v3.2.1 for official 3.14.0 final support - Updates sdist build to use Python 3.14 - Ensures prebuilt cp314 wheels are generated for Linux, macOS, and Windows - Retains Python 2.7 compatibility for legacy users
etrepum
reviewed
Oct 17, 2025
Member
|
It does look like this drops support for 3.6 and 3.7 due to cibuildwheel so the next release after this will be a minor version bump rather than a patch |
- Drops manual CIBW_BUILD override since cibuildwheel 3.2.1 includes Python 3.14 by default - Simplifies configuration and reduces future maintenance overhead
Member
|
It looks like there is work to do in order to upgrade simplejson to work without the GIL, so I don't think we should merge this or declare support for it until that happens. I do not personally have the need or interest to spend time on that in the near future, but happy to do the review if someone else contributes a PR. |
\n- add an is_gil_enabled helper that reports the interpreter's current GIL state\n- skip importing the C speedups when the GIL is disabled so nogil builds fall back to Python\n- declare the extension's Py_mod_gil slot so CPython knows the module requires the GIL
….13+ nogil compatibility
… compat.is_gil_enabled
support free-threaded python builds
Author
|
Addressed the feedback - updated _speedups.c for Python 3.14 and added GIL-aware import guards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.