feat(internal): added internal api base url for internal calls#3212
Merged
waleedlatif1 merged 2 commits intostagingfrom Feb 13, 2026
Merged
feat(internal): added internal api base url for internal calls#3212waleedlatif1 merged 2 commits intostagingfrom
waleedlatif1 merged 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile OverviewGreptile SummaryAdded support for Key changes:
Architecture improvement: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant NextJS
participant InternalAPI as Internal API Routes
participant ExternalAPI as External Services
Note over NextJS,InternalAPI: Server-Side Internal Calls
NextJS->>NextJS: getInternalApiBaseUrl()
alt INTERNAL_API_BASE_URL set
NextJS->>NextJS: Use cluster DNS (e.g., sim-app.svc.cluster.local)
else INTERNAL_API_BASE_URL not set
NextJS->>NextJS: Fallback to NEXT_PUBLIC_APP_URL
end
NextJS->>InternalAPI: POST /api/workflows/{id}/execute
InternalAPI-->>NextJS: Execution result
NextJS->>InternalAPI: POST /api/webhooks/trigger/{path}
InternalAPI-->>NextJS: Webhook processed
NextJS->>InternalAPI: GET /api/tools/custom
InternalAPI-->>NextJS: Tool definition
Note over Client,NextJS: Public-Facing Calls
Client->>NextJS: External webhook callback
NextJS->>NextJS: getBaseUrl()
NextJS-->>Client: Use NEXT_PUBLIC_APP_URL
Last reviewed commit: cc33742 |
Collaborator
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INTERNAL_API_BASE_URLsupport for server-side internal/apiself-calls with fallback toNEXT_PUBLIC_APP_URLvalues.yamland schema while preserving backward compatibility when unsetType of Change
Testing
Tested manually (ran
bun run lint,helm lint --strict, and verified rendered env output for default and override values)Checklist