Skip to content

fix(tool-input): sync cleared subblock values to tool params #3214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Feb 13, 2026
+7 −2
Merged

fix(tool-input): sync cleared subblock values to tool params #3214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...editor/components/sub-block/components/tool-input/components/tools/sub-block-renderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,13 @@ export function ToolSubBlockRenderer({
}, [toolParamValue, setStoreValue, isObjectType])

useEffect(() => {
if (storeValue == null) return
const stringValue = typeof storeValue === 'string' ? storeValue : JSON.stringify(storeValue)
if (storeValue == null && lastPushedToParamsRef.current === null) return
const stringValue =
storeValue == null
? ''
: typeof storeValue === 'string'
? storeValue
: JSON.stringify(storeValue)
Copy link

@cursor cursor bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial mount briefly clears existing tool param values

Medium Severity

On initial mount with existing non-empty tool params, the second useEffect incorrectly clears the param to ''. The first effect runs and sets lastPushedToParamsRef.current to the existing param value (e.g. "hello") via a synchronous ref mutation. The second effect then sees storeValue still as null (stale from the current render) but lastPushedToParamsRef.current is no longer null, so the guard on line 81 doesn't return early. It converts null to '' and pushes that to params via onParamChange. The value self-corrects on the next render cycle, but this creates an unnecessary clear-then-restore round-trip and extra re-renders.

Fix in Cursor Fix in Web

if (stringValue !== lastPushedToParamsRef.current) {
lastPushedToParamsRef.current = stringValue
lastPushedToStoreRef.current = stringValue
Expand Down