v0.5.90: workflow duplication improvements, model allowlist, logs performance#3226
Merged
waleedlatif1 merged 4 commits intomainfrom Feb 16, 2026
Merged
v0.5.90: workflow duplication improvements, model allowlist, logs performance#3226waleedlatif1 merged 4 commits intomainfrom
waleedlatif1 merged 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryRelease PR bundling four areas of improvement: (1) logs performance — stabilizes callbacks with refs, wraps components in
Confidence Score: 4/5
Important Files Changed
Flowchartflowchart TD
subgraph LogsPerformance["Logs Performance Optimizations"]
A["logs.tsx: useReducer + refs"] --> B["Stable callbacks (no dep changes)"]
B --> C["memo-wrapped children skip re-render"]
C --> D["LogsToolbar (memo)"]
C --> E["Dashboard (memo + structural cmp)"]
C --> F["LogsList + LogRow"]
C --> G["LogDetails (memo)"]
E --> H["StatusBar (custom equality)"]
E --> I["WorkflowsList (memo)"]
end
subgraph HoverPrefetch["Hover Prefetch Flow"]
J["LogRow onMouseEnter"] --> K["prefetchLogDetail(queryClient, logId)"]
K --> L["React Query cache populated"]
L --> M["Click → useLogDetail reads initialData from cache"]
end
subgraph Duplication["Workflow Duplication Fix"]
N["Source workflow variables"] --> O["Generate new UUIDs + build varIdMapping"]
O --> P["remapVariableIdsInSubBlocks"]
P --> Q["variables-input subblock assignments updated"]
end
subgraph ModelAllowlist["Model Allowlist"]
R["ComboBox defaultValue"] --> S{"defaultValue in evaluatedOptions?"}
S -- Yes --> T["Use defaultValue"]
S -- No --> U["Fall through to claude-sonnet-4-5 or first option"]
end
Last reviewed commit: 92b4f77 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
363
to
+379
| const handleToggleLive = useCallback(() => { | ||
| const newIsLive = !isLive | ||
| setIsLive(newIsLive) | ||
|
|
||
| if (newIsLive) { | ||
| setIsVisuallyRefreshing(true) | ||
| setTimeout(() => setIsVisuallyRefreshing(false), REFRESH_SPINNER_DURATION_MS) | ||
| logsQuery.refetch() | ||
| if (selectedLogId) { | ||
| activeLogQuery.refetch() | ||
| setIsLive((prev) => { | ||
| if (!prev) { | ||
| setIsVisuallyRefreshing(true) | ||
| const timerId = window.setTimeout(() => { | ||
| setIsVisuallyRefreshing(false) | ||
| refreshTimersRef.current.delete(timerId) | ||
| }, REFRESH_SPINNER_DURATION_MS) | ||
| refreshTimersRef.current.add(timerId) | ||
| logsRefetchRef.current() | ||
| if (selectedLogIdRef.current) { | ||
| activeLogRefetchRef.current() | ||
| } | ||
| } | ||
| } | ||
| }, [isLive, logsQuery, activeLogQuery, selectedLogId]) | ||
| return !prev | ||
| }) | ||
| }, []) |
Contributor
There was a problem hiding this comment.
Side-effects inside state updater
Calling setIsVisuallyRefreshing, window.setTimeout, and logsRefetchRef.current() inside the setIsLive updater is a side-effect within a React state updater function. While this works in practice because React batches the updates, state updaters are expected to be pure functions — React may call them more than once in strict mode or concurrent features, which would trigger duplicate timers and refetches.
Consider extracting the side-effects outside the updater:
Suggested change
| const handleToggleLive = useCallback(() => { | |
| const newIsLive = !isLive | |
| setIsLive(newIsLive) | |
| if (newIsLive) { | |
| setIsVisuallyRefreshing(true) | |
| setTimeout(() => setIsVisuallyRefreshing(false), REFRESH_SPINNER_DURATION_MS) | |
| logsQuery.refetch() | |
| if (selectedLogId) { | |
| activeLogQuery.refetch() | |
| setIsLive((prev) => { | |
| if (!prev) { | |
| setIsVisuallyRefreshing(true) | |
| const timerId = window.setTimeout(() => { | |
| setIsVisuallyRefreshing(false) | |
| refreshTimersRef.current.delete(timerId) | |
| }, REFRESH_SPINNER_DURATION_MS) | |
| refreshTimersRef.current.add(timerId) | |
| logsRefetchRef.current() | |
| if (selectedLogIdRef.current) { | |
| activeLogRefetchRef.current() | |
| } | |
| } | |
| } | |
| }, [isLive, logsQuery, activeLogQuery, selectedLogId]) | |
| return !prev | |
| }) | |
| }, []) | |
| const handleToggleLive = useCallback(() => { | |
| setIsLive((prev) => !prev) | |
| }, []) | |
| const isLiveRef = useRef(isLive) | |
| useEffect(() => { | |
| const wasLive = isLiveRef.current | |
| isLiveRef.current = isLive | |
| if (isLive && !wasLive) { | |
| setIsVisuallyRefreshing(true) | |
| const timerId = window.setTimeout(() => { | |
| setIsVisuallyRefreshing(false) | |
| refreshTimersRef.current.delete(timerId) | |
| }, REFRESH_SPINNER_DURATION_MS) | |
| refreshTimersRef.current.add(timerId) | |
| logsRefetchRef.current() | |
| if (selectedLogIdRef.current) { | |
| activeLogRefetchRef.current() | |
| } | |
| } | |
| }, [isLive]) |
| const [storeValue, setStoreValue] = useSubBlockValue(blockId, syntheticId) | ||
|
|
||
| const toolParamValue = toolParams?.[effectiveParamId] ?? '' | ||
| const isObjectType = OBJECT_SUBBLOCK_TYPES.has(subBlock.type) |
Contributor
There was a problem hiding this comment.
Mutable ref assigned during render
Assigning onParamChangeRef.current = onParamChange during render (outside a useEffect) is a side-effect during render. In React concurrent mode or strict mode, render functions may be called multiple times before commit, which can lead to stale or inconsistent ref values.
Suggested change
| const isObjectType = OBJECT_SUBBLOCK_TYPES.has(subBlock.type) | |
| const onParamChangeRef = useRef(onParamChange) | |
| useEffect(() => { | |
| onParamChangeRef.current = onParamChange | |
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.