Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to slackapi/bolt-python#1205
This test shows how, if the web socket server returns a 409 during the handshake, the client reports
is_connectedasTrue. I believe this is a bug.This relates to the WIP PR for the node SDK's socket-mode library (slackapi/node-slack-sdk#2099) which attempts to address slackapi/node-slack-sdk#2094. My intention in these PRs in bolt-python and in the python-slack-sdk is to understand the behaviour of bolt-python and compare it to how bolt-js operates.