fix: avoid infinite loops when searching for filesystem root of another drive#353
Merged
fix: avoid infinite loops when searching for filesystem root of another drive#353
Conversation
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 64.54% 64.57% +0.02%
==========================================
Files 213 213
Lines 17915 17918 +3
==========================================
+ Hits 11564 11570 +6
+ Misses 5274 5272 -2
+ Partials 1077 1076 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Draft
2 tasks
hello-ashleyintech
approved these changes
Feb 26, 2026
Contributor
hello-ashleyintech
left a comment
There was a problem hiding this comment.
this has brought back many windows memories! 🙌
| mockWorkingDirectory: filepath.Join("path", "outside", "home", "to", "project"), | ||
| expectedError: slackerror.New(slackerror.ErrHooksJSONLocation), | ||
| }, | ||
| "errors if traversal reaches a filesystem root": { |
Member
Author
|
@hello-ashleyintech I hope all good ones! Let's merge this to look out for more edge 📠 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This PR follows #178 with ongoing attempt to exit hanging installations in CI. We now check for repeated lookups when searching "up" for the project
.slackdirectory.Reviewers
These changes were proven to work on Windows with slackapi/slack-github-action#560!
Requirements