CRE-1627: arbiter status refactor; observation fallback #1752
+67
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 mchain0, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results - No breaking changes |
bolekk
reviewed
Jan 7, 2026
| p.lggr.Errorw("RingOCR failed to get arbiter scaler status", "error", err) | ||
| return nil, err | ||
| p.lggr.Errorw("RingOCR exhausted retries for arbiter scaler status, using fallback", "error", err) | ||
| // Fallback to store's previous state |
Contributor
There was a problem hiding this comment.
I'm still not convinced that we want to have fallback at all.
If arbiter is down for more than F nodes, let's just start failing OCR and we won't be able to scale until we fix those Arbiters. In fact, even if fallback somehow works, those nodes won't be able to tell their arbiters to scale ;)
Contributor
Author
There was a problem hiding this comment.
yeah, I'm not convinced myself. let's park this for now and revive if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRE-1627
Related to discussion