Skip to content

Conversation

@simsonraj
Copy link

@simsonraj simsonraj commented Oct 24, 2025

https://github.com/smartcontractkit/chainlink-deployments/actions/runs/18708625042/job/53468267687

EVM is missing WrongNonce decoded error to run the execute with skip-nonce-errors, which just happened on Sonic

Copilot AI review requested due to automatic review settings October 24, 2025 09:09
@simsonraj simsonraj requested review from a team as code owners October 24, 2025 09:09
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

🦋 Changeset detected

Latest commit: 49e0fac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
chainlink-deployments-framework Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds handling for the WrongNonce error in the EVM nonce error detection logic. The change allows the system to skip operations that encounter either WrongNonce or the existing PostOpCountReached error.

Key Changes:

  • Extended the nonce error check to include WrongNonce alongside PostOpCountReached

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@simsonraj simsonraj changed the title Add WrongNonce error for EVM to skip MCMS: Add WrongNonce error for EVM to skip Oct 24, 2025
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

ecPablo
ecPablo previously approved these changes Oct 24, 2025
Copy link
Collaborator

@jkongie jkongie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a changeset so that it gets put into the next version with a changelog item

pnpm changeset add

@simsonraj simsonraj requested a review from a team as a code owner December 1, 2025 11:28
Copilot AI review requested due to automatic review settings December 1, 2025 11:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@simsonraj simsonraj requested review from ecPablo and jkongie December 1, 2025 11:37
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@ecPablo ecPablo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simsonraj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants