Extend cldf timelock converter logic for TON #628

huangzhen1997 · 2025-12-09T22:54:21Z

Adding TON timelock converter support. Note the TON support for executor override is also added here, but there's another PR for supporting the migration to MCMS-Tools repo: https://github.com/smartcontractkit/mcms-tools/pull/261

Need to add test coverage

changeset-bot · 2025-12-09T22:54:24Z

⚠️ No Changeset found

Latest commit: a68db89

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-12-09T22:54:32Z

👋 huangzhen1997, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copilot

Pull request overview

This PR extends the CLDF (Chainlink Deployments Framework) proposal conversion logic to support the TON (The Open Network) blockchain. The changes enable TON chain integration by adding necessary converters, executors, and inspectors while also updating various dependencies.

Key changes:

Add TON support to MCMS v2 CLI with timelock converter, executor, and inspector implementations
Introduce TxOps struct to encapsulate TON transaction operation configuration
Update multiple dependencies including Go version, chainlink-ccip, mcms, and tonutils-go

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
go.mod	Updates Go version to 1.25.3 and upgrades multiple dependencies including TON-related libraries
engine/cld/legacy/cli/mcmsv2/mcms_v2.go	Adds TON chain family support with converter, executor, and inspector implementations; refactors variable naming
chain/ton/ton_chain.go	Introduces TxOps struct to hold wallet and amount configuration for transactions
chain/ton/provider/rpc_provider.go	Initializes TxOps with default transaction amount in RPC provider
chain/ton/provider/ctf_provider_test.go	Updates test to verify TxOps instead of Wallet field
chain/ton/provider/ctf_provider.go	Initializes TxOps with default amount; fixes wallet method call to use WalletAddress()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

chain/ton/provider/ctf_provider.go

krebernisak · 2025-12-10T12:10:46Z

chain/ton/provider/ctf_provider.go

 		URL:           url,
+		TxOps: cldf_ton.TxOps{
+			Wallet: tonWallet,
+			Amount: tlb.MustFromTON(defaultTxTONAmount), // default amount for transactions


Good for now, too simple to scale - we need to track this item.

We will need to be able to load gas configuration (from somewhere) which will need to tell us how much on average something costs to do (per contract call), and something a CLD user should be able to easily override.

cc @patricios-space @vicentevieytes re: per call gas configuration

…rt-ton-timelock-converter

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-12T04:26:13Z

chain/ton/provider/ctf_provider.go

 		Client:        nodeClient,
-		Wallet:        tonWallet,
-		WalletAddress: tonWallet.Address(),
+		WalletAddress: tonWallet.WalletAddress(),


The change from tonWallet.Address() to tonWallet.WalletAddress() lacks test coverage. The existing test in ctf_provider_test.go only checks that WalletAddress is not empty but doesn't verify the correct method is being called or that the address value is as expected.

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-12T04:33:34Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

+		}
+		c := cfg.blockchains.TonChains()[uint64(chainSelector)]
+
+		return ton.NewExecutor(encoder, c.Client, c.TxOps.Wallet, c.TxOps.Amount)


The newly added TON executor creation logic lacks test coverage. Consider adding tests that verify the executor is correctly created with the proper encoder, client, wallet, and amount parameters.

Copilot · 2025-12-12T04:33:34Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

 		}
+	case chainsel.FamilyTon:
+		c := cfg.blockchains.TonChains()[uint64(chainSelector)]
+		return ton.NewTimelockExecutor(c.Client, c.TxOps.Wallet, c.TxOps.Amount)


The newly added TON timelock executor creation logic lacks test coverage. Consider adding tests that verify the timelock executor is correctly instantiated with the appropriate client, wallet, and amount.

Copilot · 2025-12-12T04:33:34Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

+		chain := cfg.blockchains.TonChains()[cfg.chainSelector]
+		inspector = ton.NewInspector(chain.Client)


The newly added TON inspector creation logic lacks test coverage. Consider adding tests that verify the inspector is correctly created from the TON chain client.

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…rt-ton-timelock-converter

…lock-converter' of github.com:smartcontractkit/chainlink-deployments-framework into NONEVM-3069/extend-cldf-proposal-logic-support-ton-timelock-converter

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-16T23:02:55Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

 		}
+	case chainsel.FamilyTon:
+		c := cfg.blockchains.TonChains()[uint64(chainSelector)]
+		return ton.NewTimelockExecutor(c.Client, c.TxOps.Wallet, c.TxOps.Amount)


The TON timelock executor creation logic lacks test coverage. Consider adding tests to verify correct executor initialization with client, wallet, and amount parameters.

Copilot · 2025-12-16T23:02:56Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

 					return nil, fmt.Errorf("error creating Sui timelock converter: %w", err)
 				}
+			case chainsel.FamilyTon:
+				converter = ton.NewTimelockConverter(ton.DefaultSendAmount)


The TON timelock converter initialization is not covered by tests. Add test coverage to verify the converter is created with the correct default send amount.

Copilot · 2025-12-16T23:02:56Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

 		}
+	case chainsel.FamilyTon:
+		chain := cfg.blockchains.TonChains()[cfg.chainSelector]
+		inspector = ton.NewInspector(chain.Client)


The TON inspector creation logic lacks test coverage. Add tests to ensure the inspector is properly initialized with the chain client.

Copilot · 2025-12-16T23:02:56Z

chain/ton/provider/rpc_provider.go

 	WalletVersionV5R1    WalletVersion = "V5R1"
 	WalletVersionDefault WalletVersion = ""
+
+	defaultAmountTonString = "0.1" // Default amount in TON for transactions


The default transaction amount should be documented more clearly, explaining why 0.1 TON was chosen and under what circumstances this value might need adjustment.

Suggested change

defaultAmountTonString = "0.1" // Default amount in TON for transactions

// defaultAmountTonString defines the default amount (in TON) used when a caller

// does not explicitly specify a transaction amount.

//

// The value 0.1 TON is intentionally conservative: it is typically sufficient to

// cover standard transaction fees on mainnet and testnet while remaining small

// enough to avoid unintentionally transferring a large balance.

//

// Consumers should override this default if:

// - their workflow requires sending a larger or smaller value per transaction;

// - network fee dynamics change so that 0.1 TON is no longer adequate to cover

// gas and other on-chain costs; or

// - they operate in an environment (e.g., private/test networks) with different

// economic assumptions.

defaultAmountTonString = "0.1"

cl-sonarqube-production · 2025-12-16T23:08:18Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

gustavogama-cll · 2025-12-19T23:01:28Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

 			return nil, fmt.Errorf("invalid encoder type: %T", encoder)
 		}
-		chain := cfg.blockchains.EVMChains()[uint64(chainSelector)]
+		c := cfg.blockchains.EVMChains()[uint64(chainSelector)]


what's wrong with the word chain?

it's a nit thing, go variables with limited scope should have shorter names

jadepark-dev · 2025-12-23T10:36:07Z

chain/ton/provider/ctf_provider.go

 		Client:        nodeClient,
-		Wallet:        tonWallet,
-		WalletAddress: tonWallet.Address(),
+		WalletAddress: tonWallet.WalletAddress(),


Not related to this PR but I wonder if we need to apply this change to the rest of the codebase. Any context on bounceable address?

// Address - returns old (bounce) version of wallet address // DEPRECATED: because of address reform, use WalletAddress, // it will return UQ format func (w *Wallet) Address() *address.Address { return w.addr } // WalletAddress - returns new standard non bounce address func (w *Wallet) WalletAddress() *address.Address { return w.addr.Bounce(false) }

jadepark-dev · 2025-12-23T10:44:56Z

chain/ton/provider/ctf_provider.go

-	// airdrop the deployer wallet
-	ferr := fundTonWallets(ctx, nodeClient, []*address.Address{tonWallet.Address()}, []tlb.Coins{tlb.MustFromTON("1000")})
-	if ferr != nil {
-		return nil, fmt.Errorf("failed to fund wallet: %w", ferr)
-	}


Omitting fund logic from network setup makes sense to me(if I am reading it right), but just a reminder that integration tests in core and chainlink-ton are relying on the deployer wallet to fund transmitters:

https://github.com/smartcontractkit/chainlink/blob/331ae63b34071a820023405e3482ce2ea8d50ce9/deployment/utils/nodetestutils/fund.go#L33-L46

https://github.com/smartcontractkit/chainlink-ton/blob/082db6f6514f467bbafd94454e8f56b95a395987/deployment/utils/chain.go#L155-L161

extend cldf proposal conversion logic

3261478

huangzhen1997 requested a review from a team as a code owner December 9, 2025 22:54

Copilot AI review requested due to automatic review settings December 9, 2025 22:54

Copilot AI reviewed Dec 9, 2025

View reviewed changes

engine/cld/legacy/cli/mcmsv2/mcms_v2.go Show resolved Hide resolved

chain/ton/provider/ctf_provider.go Outdated Show resolved Hide resolved

huangzhen1997 commented Dec 9, 2025

View reviewed changes

chain/ton/provider/ctf_provider.go Outdated Show resolved Hide resolved

huangzhen1997 marked this pull request as draft December 9, 2025 23:04

huangzhen1997 changed the title ~~Extend cldf proposal conversion logic for TON~~ Extend cldf timelock converter logic for TON Dec 9, 2025

huangzhen1997 requested review from jadepark-dev and krebernisak December 9, 2025 23:05

fix goimport

ce292f9

jadepark-dev reviewed Dec 10, 2025

View reviewed changes

chain/ton/provider/ctf_provider.go Show resolved Hide resolved

krebernisak reviewed Dec 10, 2025

View reviewed changes

huangzhen1997 added 5 commits December 10, 2025 10:18

rm redundant wallet funds

76f7941

remove unused fundwallet func

6b03e06

add test coverage

bb6622b

update test

564f880

Merge branch 'main' into NONEVM-3069/extend-cldf-proposal-logic-suppo…

fa6aa6c

…rt-ton-timelock-converter

huangzhen1997 requested review from Copilot, jadepark-dev and krebernisak December 12, 2025 04:25

Copilot AI reviewed Dec 12, 2025

View reviewed changes

update

580e5c7

huangzhen1997 marked this pull request as ready for review December 12, 2025 04:33

Copilot AI review requested due to automatic review settings December 12, 2025 04:33

Copilot AI reviewed Dec 12, 2025

View reviewed changes

huangzhen1997 requested a review from ecPablo December 12, 2025 15:23

huangzhen1997 added 2 commits December 15, 2025 20:30

bump version

d139579

bump mcms version

e0493eb

Copilot AI review requested due to automatic review settings December 16, 2025 21:20

Copilot AI reviewed Dec 16, 2025

View reviewed changes

huangzhen1997 added 3 commits December 16, 2025 17:00

Merge branch 'main' into NONEVM-3069/extend-cldf-proposal-logic-suppo…

8c9b9ff

…rt-ton-timelock-converter

fix make

b703c08

Merge branch 'NONEVM-3069/extend-cldf-proposal-logic-support-ton-time…

a68db89

…lock-converter' of github.com:smartcontractkit/chainlink-deployments-framework into NONEVM-3069/extend-cldf-proposal-logic-support-ton-timelock-converter

Copilot AI review requested due to automatic review settings December 16, 2025 23:02

Copilot AI reviewed Dec 16, 2025

View reviewed changes

gustavogama-cll reviewed Dec 19, 2025

View reviewed changes

jadepark-dev reviewed Dec 23, 2025

View reviewed changes

		chain := cfg.blockchains.TonChains()[cfg.chainSelector]
		inspector = ton.NewInspector(chain.Client)

-	defaultAmountTonString = "0.1" // Default amount in TON for transactions
+	// defaultAmountTonString defines the default amount (in TON) used when a caller
+	// does not explicitly specify a transaction amount.
+	//
+	// The value 0.1 TON is intentionally conservative: it is typically sufficient to
+	// cover standard transaction fees on mainnet and testnet while remaining small
+	// enough to avoid unintentionally transferring a large balance.
+	//
+	// Consumers should override this default if:
+	//   - their workflow requires sending a larger or smaller value per transaction;
+	//   - network fee dynamics change so that 0.1 TON is no longer adequate to cover
+	//     gas and other on-chain costs; or
+	//   - they operate in an environment (e.g., private/test networks) with different
+	//     economic assumptions.
+	defaultAmountTonString = "0.1"

Extend cldf timelock converter logic for TON #628

Are you sure you want to change the base?

Extend cldf timelock converter logic for TON #628

Uh oh!

Conversation

huangzhen1997 commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

krebernisak Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

cl-sonarqube-production bot commented Dec 16, 2025

Quality Gate passed

Uh oh!

gustavogama-cll Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 Dec 21, 2025

Choose a reason for hiding this comment

Uh oh!

jadepark-dev Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 commented Dec 9, 2025 •

edited

Loading

changeset-bot bot commented Dec 9, 2025 •

edited

Loading

jadepark-dev Dec 23, 2025 •

edited

Loading