[Merge 5th Jan][CLD-910]: fix(JD): remove wsrpc config #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b9fc7e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
graham-chainlink
force-pushed
the
ggoh/cld-910/remove-jd-wsrpc-var
branch
3 times, most recently
from
0f60754 to
a597245
Compare
graham-chainlink
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused WSRPC (WebSocket RPC) configuration field from the Job Distributor (JD) client, as it was never actually needed or utilized. The change simplifies the configuration by keeping only the required GRPC endpoint.
Key Changes:
- Removed WSRPC field from JDConfig and related configuration structs
- Updated error messages and validation logic to reflect GRPC-only requirement
- Cleaned up test cases and documentation examples that referenced WSRPC
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| offchain/jd/client.go | Removed WSRPC field from JDConfig struct and JobDistributor struct |
| offchain/jd/client_test.go | Removed test case for WSRPC configuration and related assertions |
| offchain/jd/doc.go | Removed WSRPC from documentation examples and corrected OAuth2 field reference |
| offchain/jd/provider/client_provider.go | Removed WSRPC field from ClientOffchainProviderConfig and its usage |
| offchain/jd/provider/client_provider_test.go | Removed WSRPC from test configuration |
| offchain/jd/provider/ctf_provider.go | Removed WSRPC assignment in CTFOffchainProvider |
| engine/cld/offchain/offchain.go | Updated error message and validation logic to check only GRPC endpoint |
| engine/cld/offchain/offchain_test.go | Removed test cases and assertions related to WSRPC validation |
| engine/cld/environment/environment_test.go | Removed WSRPC environment variable setup and cleanup |
| engine/cld/config/env/config.go | Removed WSRPC field from JobDistributorEndpoints and environment variable mapping |
| engine/cld/config/env/config_test.go | Removed WSRPC from test configurations and environment variable mappings |
| engine/cld/config/env_test.go | Removed WSRPC assertions from environment configuration tests |
| engine/cld/config/env/testdata/config.yml | Removed wsrpc field from YAML test configuration |
| engine/cld/config/env/testdata/config_with_optional_values.yml | Removed wsrpc field from YAML test configuration |
| .changeset/true-carrots-heal.md | Added changeset documenting the breaking change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| OAuth2: tokenSource, | ||
| Creds: credentials.NewTLS(&tls.Config{}), | ||
| GRPC: "secure.jobdistributor.com:443", | ||
| Auth: tokenSource, |
Collaborator
Author
There was a problem hiding this comment.
Typo before, should be Auth instead of OAuth2
WSRPC endpoint was never really needed for the JD client, yet we are providing it in the CLD side in the config and env var, we should remove it. JIRA: https://smartcontract-it.atlassian.net/browse/CLD-910
graham-chainlink
force-pushed
the
ggoh/cld-910/remove-jd-wsrpc-var
branch
from
a597245 to
7b9fc7e
Compare
graham-chainlink
changed the title
|
gustavogama-cll
approved these changes
Jan 5, 2026
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 5, 2026
Restoring the fields but marking them deprecated and they are no longer used. This is to help with easier migration between usage in Chainlink repo and CLD repo. Related to #643 JIRA: https://smartcontract-it.atlassian.net/browse/CLD-910
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.74.0 ### Minor Changes - [#643](#643) [`ade5b2c`](ade5b2c) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - fix(JD): remove WSRPC field from JDConfig The WSRPC in JDConfig was never needed as it was never used. Only GRPC field is needed. ### Patch Changes - [#649](#649) [`fea4ff3`](fea4ff3) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - fix(JD): restore WSRPC field to help with graceful migration in chainlink repo and CLD repo --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WSRPC endpoint was never really needed for the JD client, yet we are providing it in the CLD side in the config and env var, we should remove it.
Merge once code freeze end
JIRA: https://smartcontract-it.atlassian.net/browse/CLD-910