-
Notifications
You must be signed in to change notification settings - Fork 4
ton devenv #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: NONEVM-3219/CCIP-deployer-interface
Are you sure you want to change the base?
ton devenv #470
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 5d7cb4f.
jadepark-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this. Left a few TON/repo-specific comments - feel free to consider them for follow up improvements
| m.e = e | ||
| } | ||
|
|
||
| func (m *CCIP16TON) SendMessage(ctx context.Context, src, dest uint64, fields any, opts any) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this fields and opts are configurable by test cases? Thinking about tuning test cases like with custom gas limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's just a matter of how we want to invoke them. Right now we only have a basic smoke test defined that is doing vanilla message passing, so I haven't used these params yet. https://github.com/smartcontractkit/chainlink-ccip/blob/24774b13a37b87d8f35269bb7c7627824247c262/devenv/tests/e2e/smoke_test.go#L87
| WORKFLOW_FILE: .github/workflows/test_smoke.yml | ||
| TARGET_REPO: smartcontractkit/chainlink-ccip | ||
| TARGET_BRANCH: tt/ton | ||
| TON_REF: ${{ github.head_ref || github.sha }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is the chainlink-ton plugin version resolved/built?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gets passed to the re-usable chainlink-ccip workflow which just bumps the local go.mod of a core repo that is built afterwards and used in the env.
- name: Upgrade relayer dependencies to specified commit
working-directory: ${{ github.workspace }}/chainlink-repo
shell: bash
run: |
export GOPRIVATE=github.com/smartcontractkit/*
if [ -n "${{ inputs.ton_ref }}" ]; then
go get github.com/smartcontractkit/chainlink-ton@${{ inputs.ton_ref }}
fi
if [ -n "${{ inputs.solana_ref }}" ]; then
go get github.com/smartcontractkit/chainlink-solana@${{ inputs.solana_ref }}
fi
if [ -n "${{ inputs.ccip_ref }}" ]; then
go get github.com/smartcontractkit/chainlink-ccip@${{ inputs.ccip_ref }}
fi
make gomodtidy
No description provided.