Skip fast transfer test not needed at the moment #20667
Conversation
CORA - Pending ReviewersAll codeowners have approved! ✅ Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
|
carte7000
requested review from
0xAustinWang,
agusaldasoro,
chris-de-leon-cll,
makramkd,
mateusz-sekara,
tt-cll and
winder
product-security-plaid-production
bot
requested review from
erikburt and
kalverra
There was a problem hiding this comment.
Pull request overview
This PR temporarily disables fast transfer integration tests by adding skip calls at the beginning of four test functions and removing their corresponding CI/CD pipeline configurations.
Key changes:
- Added
t.Skip()calls to disable four fast transfer test functions - Removed CI/CD pipeline entries for the skipped tests
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| integration-tests/smoke/ccip/ccip_fast_transfer_test.go | Added skip statements to four test functions (1.5 and 1.6 variants with and without MCMS) |
| .github/e2e-tests.yml | Removed CI/CD pipeline configurations for the four skipped fast transfer tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| func TestFastTransfer1_5Lanes(t *testing.T) { | ||
| t.Skip("Skipping fast transfer tests") |
There was a problem hiding this comment.
The skip message lacks context about why these tests are being skipped and when they should be re-enabled. Consider adding a more descriptive message that includes the reason (e.g., a ticket reference) and expected timeline for re-enabling, such as: t.Skip(\"Temporarily skipping fast transfer tests - see LINK-XXX for details\")
| t.Skip("Skipping fast transfer tests") | |
| t.Skip("Temporarily skipping fast transfer tests - see CCIP-XXXX for details") |
|
|
5 participants
Requires
Supports