Skip to content

CRE-1605: Ring delegate integration #20682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mchain0 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

CRE-1605: Ring delegate integration #20682

mchain0 wants to merge 2 commits into from
+163 −0

Conversation

@mchain0
Copy link
Contributor

@mchain0 mchain0 commented Dec 23, 2025 •
edited by atlassian bot
Loading

@mchain0 mchain0 requested review from a team as code owners December 23, 2025 14:02
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

👋 mchain0, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

pavel-raykov
pavel-raykov reviewed Dec 23, 2025
View reviewed changes
george-dorin
george-dorin reviewed Dec 23, 2025
View reviewed changes
core/services/chainlink/application.go
opts.DonTimeStore = dontime.NewStore(dontime.DefaultRequestTimeout)
}

if opts.RingStore == nil {
Copy link
Contributor

@george-dorin george-dorin Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be instantiated inside delegates newRingPlugin as we will spawn all of the three services there (ring, arbiter and shard-orchestrator)

@mchain0 mchain0 requested a review from agparadiso December 23, 2025 14:43
@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Dec 23, 2025

Quality Gate failed Quality Gate failed

Failed conditions
46.0% Duplication on New Code (required ≤ 10%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

@trunk-io
Copy link

trunk-io bot commented Dec 23, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@george-dorin george-dorin george-dorin left review comments

@pavel-raykov pavel-raykov pavel-raykov left review comments

@agparadiso agparadiso Awaiting requested review from agparadiso

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mchain0 @george-dorin @pavel-raykov