CCIP-8881 ccv metric views

[bukata-sa]

Adding CCV metric views to beholder client

https://smartcontract-it.atlassian.net/browse/CCIP-8881

Requires

smartcontractkit/chainlink-ccv#499

Supports

[github-actions]

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[Copilot]

Pull request overview

This PR integrates CCV (Cross-Chain Verification) metric views into the beholder monitoring client by creating a new metric aggregation function and wiring it into the telemetry initialization flow.

Key Changes:

• Added a new MetricViews() function in the ccvcommon package to aggregate executor and verifier metric views
• Updated the shell initialization to consolidate metric views from both workflows and CCV components

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
core/services/ccv/ccvcommon/monitoring.go	New file that aggregates metric views from CCV executor and verifier components
core/cmd/shell.go	Updated telemetry initialization to use a new MetricViews() function that includes both workflow and CCV metrics

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Preallocating the slice capacity would avoid potential reallocation during append operations. Consider estimating the total number of views from both monitoring packages.

Suggested change

	views := make([]sdkmetric.View, 0)
	views = append(views, workflowsmonitoring.MetricViews()...)
	views = append(views, ccvcommon.MetricViews()...)
	workflowViews := workflowsmonitoring.MetricViews()
	ccvViews := ccvcommon.MetricViews()
	views := make([]sdkmetric.View, 0, len(workflowViews)+len(ccvViews))
	views = append(views, workflowViews...)
	views = append(views, ccvViews...)

[Copilot]

Preallocating the slice capacity would avoid potential reallocation during append operations. Consider estimating the total number of views from both executor and verifier monitoring packages.

Suggested change

	views := make([]sdkmetric.View, 0)
	views = append(views, executormonitoring.MetricViews()...)
	views = append(views, verifiermonitoring.MetricViews()...)
	executorViews := executormonitoring.MetricViews()
	verifierViews := verifiermonitoring.MetricViews()
	totalViews := len(executorViews) + len(verifierViews)
	views := make([]sdkmetric.View, 0, totalViews)
	views = append(views, executorViews...)
	views = append(views, verifierViews...)