Bindings audit fixes #213
Open
Bindings audit fixes #213
+215
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 silaslenihan, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
silaslenihan
force-pushed
the
bindings-audit-fixes
branch
from
4d847a9 to
19c4dea
Compare
✅ Abigen Fork Check PassedThe forked abigen package is up to date with the latest go-ethereum release.
No action required. |
silaslenihan
force-pushed
the
bindings-audit-fixes
branch
from
19c4dea to
f239b4e
Compare
|
| Version | Value |
|---|---|
| Current Fork | v1.14.2 |
| Latest Upstream | v1.16.7 |
Action Required
- Review upstream changes
- Check the go-ethereum releases for security advisories
- Evaluate if updates to
accounts/abi/bindaffect our fork incmd/generate-bindings/bindings/abigen/ - If necessary, sync the relevant changes and update
FORK_METADATA.md
⚠️ Potential Security-Related Commits Detected
- cmd/geth: remove deprecated vulnerability check command (#33498) (link)
- cmd/keeper/go.mod: bump github.com/consensys/gnark-crypto from 0.18.0 to 0.18.1 in /cmd/keeper (#33256) (link)
Files to Review
cmd/generate-bindings/bindings/abigen/bind.gocmd/generate-bindings/bindings/abigen/bindv2.gocmd/generate-bindings/bindings/abigen/template.go
silaslenihan
force-pushed
the
bindings-audit-fixes
branch
from
f239b4e to
9abe44f
Compare
|
| Version | Value |
|---|---|
| Current Fork | v1.14.2 |
| Latest Upstream | v1.16.7 |
Action Required
- Review upstream changes
- Check the go-ethereum releases for security advisories
- Evaluate if updates to
accounts/abi/bindaffect our fork incmd/generate-bindings/bindings/abigen/ - If necessary, sync the relevant changes and update
FORK_METADATA.md
⚠️ Potential Security-Related Commits Detected
- cmd/geth: remove deprecated vulnerability check command (#33498) (link)
- cmd/keeper/go.mod: bump github.com/consensys/gnark-crypto from 0.18.0 to 0.18.1 in /cmd/keeper (#33256) (link)
Files to Review
cmd/generate-bindings/bindings/abigen/bind.gocmd/generate-bindings/bindings/abigen/bindv2.gocmd/generate-bindings/bindings/abigen/template.go
silaslenihan
force-pushed
the
bindings-audit-fixes
branch
from
9abe44f to
3ac4d2e
Compare
|
| Version | Value |
|---|---|
| Current Fork | v1.14.2 |
| Latest Upstream | v1.16.7 |
Action Required
- Review abigen changes in upstream (only the
accounts/abi/binddirectory matters) - Compare with our fork in
cmd/generate-bindings/bindings/abigen/ - If relevant changes exist, sync them and update
FORK_METADATA.md - If no abigen changes, just update the version in
FORK_METADATA.mdtov1.16.7
⚠️ Potential Security-Related Commits Detected
- cmd/geth: remove deprecated vulnerability check command (#33498) (link)
- cmd/keeper/go.mod: bump github.com/consensys/gnark-crypto from 0.18.0 to 0.18.1 in /cmd/keeper (#33256) (link)
Files to Review
cmd/generate-bindings/bindings/abigen/bind.gocmd/generate-bindings/bindings/abigen/bindv2.gocmd/generate-bindings/bindings/abigen/template.go
silaslenihan
force-pushed
the
bindings-audit-fixes
branch
from
3ac4d2e to
f8f1308
Compare
|
| Version | Value |
|---|---|
| Current Fork | v0.14.2 |
| Latest Upstream | v1.16.7 |
Action Required
- Review abigen changes in upstream (only the
accounts/abi/binddirectory matters) - Compare with our fork in
cmd/generate-bindings/bindings/abigen/ - If relevant changes exist, sync them and update
FORK_METADATA.md - If no abigen changes, just update the version in
FORK_METADATA.mdtov1.16.7
⚠️ Potential Security-Related Commits Detected
- cmd/geth: remove deprecated vulnerability check command (#33498) (link)
- cmd/keeper/go.mod: bump github.com/consensys/gnark-crypto from 0.18.0 to 0.18.1 in /cmd/keeper (#33256) (link)
Files to Review
cmd/generate-bindings/bindings/abigen/bind.gocmd/generate-bindings/bindings/abigen/bindv2.gocmd/generate-bindings/bindings/abigen/template.go
silaslenihan
force-pushed
the
bindings-audit-fixes
branch
from
f8f1308 to
3c178b8
Compare
|
| Version | Value |
|---|---|
| Current Fork | v0.16.0 |
| Latest Upstream | v1.16.7 |
Action Required
- Review abigen changes in upstream (only the
accounts/abi/binddirectory matters) - Compare with our fork in
cmd/generate-bindings/bindings/abigen/ - If relevant changes exist, sync them and update
FORK_METADATA.md - If no abigen changes, just update the version in
FORK_METADATA.mdtov1.16.7
⚠️ Potential Security-Related Commits Detected
- cmd/geth: remove deprecated vulnerability check command (#33498) (link)
- cmd/keeper/go.mod: bump github.com/consensys/gnark-crypto from 0.18.0 to 0.18.1 in /cmd/keeper (#33256) (link)
Files to Review
cmd/generate-bindings/bindings/abigen/bind.gocmd/generate-bindings/bindings/abigen/bindv2.gocmd/generate-bindings/bindings/abigen/template.go
silaslenihan
force-pushed
the
bindings-audit-fixes
branch
from
3c178b8 to
ec2782d
Compare
✅ Abigen Fork Check PassedThe forked abigen package is up to date with the latest go-ethereum release.
No action required. |
silaslenihan
force-pushed
the
bindings-audit-fixes
branch
from
ec2782d to
dedbf81
Compare
✅ Abigen Fork Check PassedThe forked abigen package is up to date with the latest go-ethereum release.
No action required. |
silaslenihan
force-pushed
the
bindings-audit-fixes
branch
from
dedbf81 to
acdcb6c
Compare
✅ Abigen Fork Check PassedThe forked abigen package is up to date with the latest go-ethereum release.
No action required. |
silaslenihan
force-pushed
the
bindings-audit-fixes
branch
from
acdcb6c to
b3c1f40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of outdated test comment: #213 (comment) (removed successful comment because it was too noisy).