Skip to content

Conversation

@krebernisak
Copy link
Contributor

No description provided.

@krebernisak krebernisak requested a review from a team as a code owner September 25, 2025 15:25
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2025

🦋 Changeset detected

Latest commit: cfba89d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@smartcontractkit/mcms Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@krebernisak krebernisak marked this pull request as draft September 25, 2025 15:25
Copy link
Contributor

@gustavogama-cll gustavogama-cll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few requests, if you please.

  1. add a changeset file
  2. remove the .envrc file. We don't mind if you want to use nix, but we don't want to enforce it by default
  3. consider adding unit tests; I understand it's just an initial PR, but we do try have good coverage in the library. Ideally, in every PR.

@gustavogama-cll
Copy link
Contributor

I see the PR was marked as draft later... If it's not ready for review yet, please ignore my remarks.

@krebernisak
Copy link
Contributor Author

I see the PR was marked as draft later... If it's not ready for review yet, please ignore my remarks.

Thx for a quick review! Yeah, still an early draft trying to move things forward.

@krebernisak krebernisak force-pushed the feat/ton-support branch 4 times, most recently from 01797f9 to 3e808a9 Compare November 3, 2025 12:48
@krebernisak krebernisak marked this pull request as ready for review November 3, 2025 14:10
@krebernisak krebernisak force-pushed the feat/ton-support branch 2 times, most recently from c565020 to 79ba4bc Compare December 17, 2025 11:46
Comment on lines +91 to +93
// Construct a proposal

// Construct a TON transaction to grant a role

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Are these TODOs?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, just section titles. Feel free to ignore

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
70.9% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants