Merged
Conversation
eadf
reviewed
Aug 14, 2025
| * Transparently optimise `iter_{set|unset}_bits(...).count()` to use platform | ||
| "count bits" directly, rather than forcing the full iterator to execute. | ||
| Depending on your machine, this can lead to savings of 2-3 orders of magnitude. | ||
|
|
Contributor
There was a problem hiding this comment.
I don't know if it worth mentioning, but we updated the 'normal' interator.count() too.
It now does math instead of exhausting the iterator (range.count())
Member
Author
There was a problem hiding this comment.
I did think briefly think about adding that in, but I came down on the side of "don't distract readers from the major things that will benefit them". I think the iter_bits.count() optimisation is something that a lot of users will really benefit from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.