Create more elaborate base class for curation plugins #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nheeb
reviewed
Oct 7, 2025
sdruskat
approved these changes
Oct 10, 2025
Contributor
sdruskat
left a comment
sdruskat
left a comment
There was a problem hiding this comment.
Thanks! Some comments, of which only one is more than minor:
Should the default case be a plugin? It's an architectural (and project management) decision to be made. All plugins are meant to be extracted, should there be an exemption for default cases on the command level?
Co-authored-by: Stephan Druskat <sdruskat@users.noreply.github.com>
zyzzyxdonta
force-pushed
the
feature/440-curation-step-base-class
branch
from
72995e6 to
df0ea0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request establishes a base class for curation plugins and implements the old dummy curation in terms of this class.
Closes #440