Skip to content

Conversation

@vaibhavbhalla2505
Copy link
Contributor

Description

This pull request introduces several dependency and documentation updates, along with minor code style improvements and expanded TypeScript build artifacts. The most notable changes include updating Node.js and package dependencies, expanding the documentation for LoopBack extensions, and refactoring class declarations for consistency.

Fixes #2388

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

Copilot AI review requested due to automatic review settings January 2, 2026 09:21
@vaibhavbhalla2505 vaibhavbhalla2505 changed the title Gh 2388 chore(deps): fix vulnerability Jan 2, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses issue #2388 by updating dependencies, documentation, and applying code style improvements. The primary changes involve downgrading @types/moment to a specific version, refactoring JWT secret handling in test files to use environment variables, updating class declarations for consistent formatting, and bumping service version numbers.

  • Standardized test authentication by moving hardcoded JWT secrets to environment variables
  • Applied consistent code formatting to class declarations across multiple provider files
  • Updated package dependencies including Node.js versions and type definitions

Reviewed changes

Copilot reviewed 157 out of 168 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
services/video-conferencing-service/package.json Downgraded @types/moment version
services/scheduler-service/src/tests/* Moved JWT secrets to environment variables in test files
services/authentication-service/src/providers/* Reformatted class declarations for consistency
packages/core/package.json Updated @types/moment version
package.json Updated lerna version and added qs override
.github/workflows/*.yml Updated Node.js version in CI workflows
README.md Added new LoopBack extension entries
Files not reviewed (2)
  • sandbox/chat-notification-pubnub-example/facade/package-lock.json: Language not supported
  • sandbox/chat-notification-socketio-example/facade/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

uses: actions/setup-node@v4
with:
node-version: '22.x'
node-version: '20.x'
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgrading from Node.js 22.x to 20.x in the release workflow could cause inconsistencies if the codebase relies on Node.js 22 features. Ensure all Node.js 22-specific features have been removed or that this downgrade is intentional and documented.

Suggested change
node-version: '20.x'
node-version: '22.x'

Copilot uses AI. Check for mistakes.
running command...
$ sl (-v|--version|version)
@sourceloop/cli/12.2.0 linux-x64 node-v22.21.1
@sourceloop/cli/12.2.0 darwin-arm64 node-v22.17.1
Copy link

Copilot AI Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The platform change from 'linux-x64' to 'darwin-arm64' and node version from 'v22.21.1' to 'v22.17.1' in the README suggests this was modified on a specific developer's machine. Documentation examples should use consistent, generic platform information or be regenerated in CI to avoid confusion.

Suggested change
@sourceloop/cli/12.2.0 darwin-arm64 node-v22.17.1
@sourceloop/cli/12.2.0 <platform> node-<version>

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2026

@yeshamavani yeshamavani merged commit b82fef5 into master Jan 2, 2026
8 checks passed
@yeshamavani yeshamavani deleted the GH-2388 branch January 2, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix sonarqube issues and update readme

3 participants