Use spring-release-actions/announce-on-gchat #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses common action for GChat release announcements Signed-off-by: Josh Cummings <3627351+jzheaux@users.noreply.github.com>
artembilan
requested changes
Jan 21, 2026
Contributor
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
This is great!
Thank you!
| curl -X POST '${{ env.CHAT_WEBHOOK_URL }}' -H 'Content-Type: application/json' -d '{ text: "${{ github.event.repository.name }}-announcing `${{ inputs.milestone }}`"}' | ||
| env: | ||
| CHAT_WEBHOOK_URL: ${{ secrets.SPRING_RELEASE_CHAT_WEBHOOK_URL }} | ||
| if: secrets.SPRING_RELEASE_CHAT_WEBHOOK_URL != '' |
Contributor
There was a problem hiding this comment.
Do we really need != ''?
I thought if: does the trick against empty strings easily.
| uses: spring-io/spring-release-actions/announce-on-gchat@0.0.1 | ||
| with: | ||
| gchat-webhook-url: ${{ secrets.SPRING_RELEASE_CHAT_WEBHOOK_URL }} | ||
| project-name: ${{ github.event.repository.name }} |
Contributor
There was a problem hiding this comment.
I think this is exactly what announce-on-gchat action does by default:
return this._projectName || process.env.GITHUB_REPOSITORY.split("/")[1];
This commit restores the original conditional, given that secrets are not accessible in conditionals. It also relies on the announce-to-gchat project name defaut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses common action for GChat release announcements