Fix 13 parser tests with various EXPLAIN AST improvements #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parser changes: - Add TableJoin for comma-separated table functions (cross join syntax) EXPLAIN formatting changes: - Fix SAMPLE clause output with proper ratio formatting - Fix empty array literals to use Function array format when aliased - Fix DESC/DESCRIBE to use DescribeQuery with TableExpression format - Fix CREATE USER to omit username from explain output Enabled tests (8 explain fixes): - 02467_cross_join_three_table_functions - 02265_cross_join_empty_list - 02896_illegal_sampling - 02482_if_with_nothing_argument - 02326_settings_changes_system_table - 03254_test_alter_user_no_changes - 01605_drop_settings_profile_while_assigned - 02001_add_default_database_to_system_users Enabled tests (6 parse_error): - 02474_create_user_query_fuzzer_bug - 01604_explain_ast_of_nonselect_query - 02128_apply_lambda_parsing - 02469_fix_aliases_parser - 02472_segfault_expression_parser - 02474_fix_function_parser_bug Regression (1 test marked as todo): - 01116_cross_count_asterisks (cross join fix causes TableJoin mismatch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser changes:
EXPLAIN formatting changes:
Enabled tests (8 explain fixes):
Enabled tests (6 parse_error):
Regression (1 test marked as todo):